Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

Create d.toml #111

Merged
merged 7 commits into from Jul 23, 2020
Merged

Create d.toml #111

merged 7 commits into from Jul 23, 2020

Conversation

CodeLongAndProsper90
Copy link
Contributor

@CodeLongAndProsper90 CodeLongAndProsper90 commented Jun 23, 2020 •
edited

Add support for the D programming language to polygott.

CodeLongAndProsper90 and others added 2 commits June 22, 2020 20:45
@CodeLongAndProsper90
Create d.toml
3b6da63 
Add support for the D programming language to polygott.
@PotentialStyx
Update d.toml
a311817 
Fixed a few errors:
extensions not aliases
each part of command is new list entry for compile
gdc not dgc
@PotentialStyx
Copy link
Contributor

PotentialStyx commented Jun 23, 2020 •
edited

Look at my or over on CodeLongAndProsper90:patch-2

dan-stowell
dan-stowell reviewed Jul 13, 2020
View reviewed changes
languages/d.toml Outdated
command = [
"gdc",
"-g",
"main.d"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing cc1d: error: module main from file main.d is specified twice on the command line in the tests: https://app.circleci.com/pipelines/github/replit/polygott/244/workflows/30b4f5a9-1a25-4922-8bd0-32822468c223/jobs/474/steps

Can you try run make test-d and see what's up on your end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it, turns out polygott was appending main.d to the end on the run command.

@CodeLongAndProsper90
Copy link
Contributor Author

It seems like the ci fails are from python-3, not from dlang.

@dan-stowell
Copy link
Contributor

dan-stowell commented Jul 20, 2020 •
edited

They are, @CodeLongAndProsper90! I merged #131 to fix the problem. Can you merge master onto your fork? That should trigger a rerun. I'll merge once it's ✅

@CodeLongAndProsper90
Copy link
Contributor Author

Sorry, new at PRs, how would I do that?

@dan-stowell
Copy link
Contributor

Sorry, new at PRs, how would I do that?

@CodeLongAndProsper90, follow these instructions to get master on your fork up-to-date: https://docs.github.com/en/enterprise/2.13/user/articles/merging-an-upstream-repository-into-your-fork

After you've successfully got master up-to-date, you can run

git checkout patch-2
git merge master
git push

and that should trigger the tests. Sorry for the rigamarole!

dan-stowell
dan-stowell approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@dan-stowell dan-stowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A++++ would add D again!

@dan-stowell dan-stowell merged commit 1046fad into replit:master Jul 23, 2020
@CodeLongAndProsper90 CodeLongAndProsper90 deleted the patch-2 branch July 23, 2020 17:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dan-stowell dan-stowell dan-stowell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CodeLongAndProsper90 @PotentialStyx @dan-stowell