This repository has been archived by the owner on May 4, 2022. It is now read-only.
[python] Fix the debugger wrapper #277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously due to how `runpy.run_path` works, the commandline to scripts ended up as being `main.py main.py`, which confuses `unittest.main()`. This change removes `sys.argv[0]` in the debugger wrapper so that `runpy.run_path` ends up with an argv of just `main.py`.
masad-frost
approved these changes
Oct 10, 2021
|
polygott is silly. i'll fix it in nix. |
auto-merge was automatically disabled
October 11, 2021 02:47
Pull request was closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously due to how
runpy.run_pathworks, the commandline to scriptsended up as being
main.py main.py, which confusesunittest.main().This change removes
sys.argv[0]in the debugger wrapper so thatrunpy.run_pathends up with an argv of justmain.py.