chore: relax flask dependency constraint #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blast-hardcheese
force-pushed
the
rtm-01-05-relax-flask-constraint
branch
2 times, most recently
from
5b1feb6
to
a206c31
Compare
Why === * Flask released a 3.0.0 version, which we couldn't support because of our version bounds. The changelog https://flask.palletsprojects.com/en/3.0.x/changes/ looks innocuous for our purposes What changed === * Changed pyproject.toml to use >=2.0.0 instead of ^2.0.0 * nix run nixpkgs#poetry -- lock --no-update Test plan === * try installing this verison in a repl after it is released * nix run nixpkgs#poetry -- check --lock
blast-hardcheese
force-pushed
the
rtm-01-05-relax-flask-constraint
branch
from
a206c31
to
7ab9ece
Compare
blast-hardcheese
approved these changes
Jan 17, 2024
blast-hardcheese
force-pushed
the
rtm-01-05-relax-flask-constraint
branch
from
7ab9ece
to
3d8ff11
Compare
Old version has different semantics and is compatible with new version anyway
blast-hardcheese
force-pushed
the
rtm-01-05-relax-flask-constraint
branch
from
3d8ff11
to
7455b9a
Compare
blast-hardcheese
added
the
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
https://flask.palletsprojects.com/en/3.0.x/changes/ looks innocuous for our purposes
What changed
Test plan
Rollout
Describe any procedures or requirements needed to roll this out safely (or check the box below)