Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WriteStream implementation #132

Merged
merged 1 commit into from
May 21, 2024
Merged

WriteStream implementation #132

merged 1 commit into from
May 21, 2024

Conversation

masad-frost
Copy link
Member

Why

Implementation for read stream from #111

and #118

What changed

Pretty straight forward implementation for this one. It's good enough for now to serve the purpose.

Versioning

  • Breaking protocol change
  • Breaking ts/js API change

@masad-frost masad-frost requested a review from a team as a code owner May 21, 2024 00:06
@masad-frost masad-frost requested review from jackyzha0 and removed request for a team May 21, 2024 00:06
@masad-frost masad-frost mentioned this pull request May 21, 2024
32 tasks
Copy link
Contributor

@Monkatraz Monkatraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice and simple

@masad-frost masad-frost merged commit cc48498 into protocolv2 May 21, 2024
3 checks passed
@masad-frost masad-frost deleted the fm-write-stream-impl branch May 21, 2024 18:05
masad-frost added a commit that referenced this pull request May 21, 2024
masad-frost added a commit that referenced this pull request May 21, 2024
masad-frost added a commit that referenced this pull request May 29, 2024
masad-frost added a commit that referenced this pull request May 31, 2024
masad-frost added a commit that referenced this pull request Jun 6, 2024
masad-frost added a commit that referenced this pull request Jun 11, 2024
masad-frost added a commit that referenced this pull request Jun 13, 2024
masad-frost added a commit that referenced this pull request Jun 20, 2024
masad-frost added a commit that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants