[protocolv2] Ignore follow up messages to a stream after server aborts it #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkatraz
approved these changes
Jun 17, 2024
Comment on lines
+791
to
+823
| add(item: string) { | ||
| if (this.items.has(item)) { | ||
| this.items.delete(item); | ||
| } else if (this.items.size >= this.maxItems) { | ||
| const first = this.items.values().next(); | ||
| if (!first.done) { | ||
| this.items.delete(first.value); | ||
| } | ||
| } | ||
| this.items.add(item); | ||
| } |
jackyzha0
requested changes
Jun 17, 2024
masad-frost
commented
Jun 17, 2024
masad-frost
force-pushed
the
fm-invalid-requests
branch
from
6618a10
to
04eaac6
Compare
jackyzha0
approved these changes
Jun 18, 2024
masad-frost
force-pushed
the
fm-tombstones
branch
from
a232b6d
to
bad8e76
Compare
masad-frost
added a commit
that referenced
this pull request
Jun 20, 2024
…s it (#204) ## Why When the server aborts a stream (due to invalid request or explicit abort) the client send more messages before it gets the abort. We should make sure this doesn't lead to errors and unnecessary follow up responses. ## What changed Keep an LRU of aborted streams, if a new message comes in for a stream in our set, we simply ignore the message.
masad-frost
added a commit
that referenced
this pull request
Jun 24, 2024
…s it (#204) ## Why When the server aborts a stream (due to invalid request or explicit abort) the client send more messages before it gets the abort. We should make sure this doesn't lead to errors and unnecessary follow up responses. ## What changed Keep an LRU of aborted streams, if a new message comes in for a stream in our set, we simply ignore the message.
masad-frost
added a commit
that referenced
this pull request
Jun 24, 2024
…s it (#204) ## Why When the server aborts a stream (due to invalid request or explicit abort) the client send more messages before it gets the abort. We should make sure this doesn't lead to errors and unnecessary follow up responses. ## What changed Keep an LRU of aborted streams, if a new message comes in for a stream in our set, we simply ignore the message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When the server aborts a stream (due to invalid request or explicit abort) the client send more messages before it gets the abort. We should make sure this doesn't lead to errors and unnecessary follow up responses.
What changed
Keep an LRU of aborted streams, if a new message comes in for a stream in our set, we simply ignore the message.