release 5.3.0 with our patches

[szymonkaliski]

This branch is checked out at a commit that was made with 5.3.0 release on official xterm.js repo: xtermjs@2e02c37

This branch also contains all of our patches.

The release process is as follows:

1. use node 18

2. run:

    yarn --frozen-lockfile
    yarn setup
    yarn package

3. and finally npm login && npm publish

We originally published @replit/xterm.js version 5.3.0 from master which is a bunch of commits ahead of this one, and introduces a bug with unicode. I unpublished that version, and will re-publish this as 5.3.0 on Monday (need to wait 24h for npm to allow us to publish the same package version again, for whatever reason).

---

EDIT: after testing, I also had to pull in xtermjs#4785 as it fixes an issue with Cannot read properties of undefined (reading 'onRequestRedraw') which we started getting when disposing shell/console. This patch will land with 5.4.0 which is in beta right now.

I also decided to call our version {x}.{y}.{z}-patched.{num} so it's bit clearer what we're doing, and we can keep updating the num without having to bump minor/patch number.

[szymonkaliski]

@ink404 @bradymadden97 tagging you here to review if nothing got lost along the way (I'm terrible at git everything), and also in "FYI" fashion.

[ink404]

Was adding this intentional?

[szymonkaliski]

this was introduced in here #5 CC @bradymadden97

[ink404]

Ah awesome, missed that PR a while back

[bradymadden97]

These were probably generated by the ROR github import 🤷

[ink404]

+1 are we publishing this as a nix package? it was previously only published to be used as an npm dep

[szymonkaliski]

no, just npm, again comes from that PR #5

[ink404]

lgtm, thank you @szymonkaliski!

Would hold off for Brady to chick his changes though

[szymonkaliski]

Yes, definitely; tbh. I'm not sure what merging this will do -- roll back master? I doubt it... But I wanted to have a branch that points to the stable release at least.

[bradymadden97]

LGTM, I released 5.3.0 yesterday though, is this just catching github up to what's released? Or are there new changes?

If new changes, we need to build as 5.3.1 and then release again.

In general I think we should probably merge to github main first then release

[bradymadden97]

These were probably generated by the ROR github import 🤷

[szymonkaliski]

@bradymadden97 I tried explaining the issues in the PR description, mainly this:

We originally published @replit/xterm.js version 5.3.0 from master which is a bunch of commits ahead of this one, and introduces a bug with unicode. I unpublished that version, and will re-publish this as 5.3.0 on Monday (need to wait 24h for npm to allow us to publish the same package version again, for whatever reason).