Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enabling experiments #68

Merged
merged 2 commits into from Aug 10, 2022
Merged

Fix enabling experiments #68

merged 2 commits into from Aug 10, 2022

Conversation

colin273
Copy link
Member

@colin273 colin273 commented Aug 9, 2022

Fix the Discord experiments toggle. (Thank you Beef, I used the marked-up snippet here.) The only catch is that disabling experiments only sets the setting; it doesn’t actually disable them until the user reloads.

Comment on lines +45 to +47
async function disableExperiments () {
hasEnabled = false;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider showing users a modal with info about a required reload before experiments are fully disabled.

Copy link
Contributor

@lleyton lleyton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nya

@lleyton lleyton merged commit a1af079 into main Aug 10, 2022
@lleyton lleyton deleted the fix-experiments branch August 10, 2022 09:16
@lleyton lleyton mentioned this pull request Aug 10, 2022
2 tasks
@MichaelDavidGK
Copy link

image
Discord crashes

@thennothinghappened
Copy link
Contributor

what did you do to cause this?

@MichaelDavidGK
Copy link

MichaelDavidGK commented Aug 10, 2022

what did you do to cause this?

just updated to latest which required reload, it crashes at start of discord

@thennothinghappened
Copy link
Contributor

not happening for me. I'll have a look but it's most likely one of your plugins

@MichaelDavidGK
Copy link

not happening for me. I'll have a look but it's most likely one of your plugins

I'm removing all plugins and will be adding one by one to see if that's the issue, will take me a while cause I'm busy with something else rn (15 minutes?)

@MichaelDavidGK
Copy link

Apparently it's PluginRepo from BD crashing it even tho nothing changed except Replugged update, welp I will live without it tbf

@thennothinghappened
Copy link
Contributor

weird, but good that's all cleared up now!

@asportnoy asportnoy restored the fix-experiments branch August 10, 2022 12:25
asportnoy added a commit that referenced this pull request Aug 10, 2022
asportnoy added a commit that referenced this pull request Aug 10, 2022
Revert "Fix enabling experiments (#68)"

This reverts commit a1af079.
@asportnoy
Copy link
Member

Reverted this since it caused some issues and didn't work properly for everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants