Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plugin links look like build overrides #69

Closed
colin273 opened this issue Aug 9, 2022 · 6 comments · Fixed by #28
Closed

Make plugin links look like build overrides #69

colin273 opened this issue Aug 9, 2022 · 6 comments · Fixed by #28
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@colin273
Copy link
Member

colin273 commented Aug 9, 2022

Describe the feature request
Use Discord’s build override component, but for plugin links. That way it hides the fairly lengthy URL and fits right in with how Discord does things. (From the thread on suggestion 32 on the Discord server)

What Plugin would it be for?
N/A

Expected behavior
N/A

@colin273 colin273 added enhancement New feature or request available (leave comment to claim) If you're interested in taking on this issue, please leave a comment! labels Aug 9, 2022
@lexisother
Copy link
Member

lexisother commented Aug 9, 2022

I am working on this already: #28

However, the PR is being upheld by the backend store endpoints that aren't implemented yet.

@asportnoy
Copy link
Member

Could you make it work without the store and then implement that letter for store plugins?

@Vap0r1ze
Copy link
Contributor

It should be noted that #28 at the moment is implimenting a differently styled embed than this issue is asking for (reusing Build Override components)

@lexisother
Copy link
Member

Could you make it work without the store and then implement that letter for store plugins?

It already works without store plugins. But I thought I would keep it draft until the store was added so I could migrate the code.

@lexisother
Copy link
Member

It should be noted that #28 at the moment is implimenting a differently styled embed than this issue is asking for (reusing Build Override components)

No it isn't. It's quite literally a build override embed. Did you even test locally? (yes, there's a bug to squash. but I stopped working due to the store not being present.)

2022-07-27_11-59-31.mp4

@Vap0r1ze
Copy link
Contributor

I'm so sorry lol, it was a poorly made assumption

@asportnoy asportnoy removed the available (leave comment to claim) If you're interested in taking on this issue, please leave a comment! label Aug 11, 2022
@asportnoy asportnoy linked a pull request Aug 11, 2022 that will close this issue
@lexisother lexisother added this to the 3.2.0 milestone Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants