-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Allow custom S3 endpoint #534
Conversation
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
=========================================
Coverage 99.32% 99.33%
- Complexity 1884 1885 +1
=========================================
Files 300 300
Lines 5970 5973 +3
=========================================
+ Hits 5930 5933 +3
Misses 40 40
Continue to review full report at Codecov.
|
Using the following environment variables, I was able to save files correctly to S3
|
@akondas The following PR has been locally tested and verified as correctly working for our internal S3 set-up. Should work with most if not all Minio instances out there. Could you please review and possibly approve + merge this new feature? If you're not the right person for this, could you mention the correct person(s) for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good.
Allow a custom S3 endpoint, used when not using AWS but a different S3 provider that is AWS compatible.