Add support for PHP 8.0

[xvilo]

This does upgrade the code to allow for PHP 8.0, which can be merged as-is if #579 is something we do not want to add. However, if we want to add #579, then I can update this PR with the accompanying Rector changes :)

[xvilo]

@akondas can you tell me how buddy works, it seems it's not pickup the runner config change. According to the logs, the used CI image is still 7.4

[akondas]

I need to approve these changes, but there is also a problem with the public instance, it needs to be prepared for php 8

[akondas]

I have to think about how to do it so that it would not be downtime, I would have to install php 8 there beforehand, which is actually to be done

[akondas]

I still have something to finish this week, but from next week I will sit down to the repman and I will try to catch up with all PR (not only this one). We will catch up with this - I promise 😉

[xvilo]

I have to think about how to do it so that it would not be downtime

The best would then be to "PHP": "7.4 || 8.0", merge this, update your vhost with the right PHP(-fpm) instance, and do a reload. Then we can fully move the codebase to 8.0, do you want me to update this one?

For compatibility we could already move CI to 8, so it does the checking and stuffs

[akondas]

yes, good approach, that should allow the update to be done without downtime, thanks for help 👍

[xvilo]

@akondas I've pushed the suggested update, just have to wait for the CI. If this is green, can you review and merge this PR?

[xvilo]

I'm unsure why the CI fails, it should be fine. It appears it might install the dependencies from some sort of cached vendor dir. I could use some help with this :)

[xvilo]

@akondas can you do another check for this PR?

[xvilo]

@marmichalski / @akondas everything has been addressed, how is this PR looking now?

[94noni]

👍🏻

[xvilo]

@akondas lets finish this?

[marmichalski]

👍

[akondas]

So from my point of view, plan looks like this:

• allow to use php 8 in composer.json
• switch pipeline to php 8
• upgrade public instance to php 8
• upgrade code (composer.lock) to php 8
• drop support for php 7.4

We are on first point here, so please do not run composer update on php 8.

[Jeroeny]

You can do this in composer.json to keep composer.lock depdencies on 7.4 for now:

"config":
        "platform": {
            "php": "7.4"
        },

[xvilo]

I have applied @Jeroeny's suggestion and installed a 7.4 compatible set of dependencies.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (423985c) 0.00% compared to head (ca923ae) 99.02%.

❗ Current head ca923ae differs from pull request most recent head 8b24958. Consider uploading reports for the commit 8b24958 to get more accurate results

Additional details and impacted files

@@              Coverage Diff              @@
##             master     #580       +/-   ##
=============================================
+ Coverage          0   99.02%   +99.02%     
- Complexity        0     1907     +1907     
=============================================
  Files             0      301      +301     
  Lines             0     5763     +5763     
=============================================
+ Hits              0     5707     +5707     
- Misses            0       56       +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[xvilo]

@akondas everything's green, with support for 8.0

[xvilo]

@akondas do you have some time to take a look at it?

[akondas]

Ok, let's go with this. Please resolve conflicts and we can merge this.

[xvilo]

From what I have found so far it that it appears to read the versions of the project itself in the test?
The buffered IO contains the following logs:

Reading composer.json of repman-io/repman (0.1.0)\n
Importing tag 0.1.0 (0.1.0.0)\n
Reading composer.json of repman-io/repman (0.1.1)\n
Importing tag 0.1.1 (0.1.1.0)\n
Reading composer.json of repman-io/repman (0.1.2)\n
Importing tag 0.1.2 (0.1.2.0)\n
Reading composer.json of repman-io/repman (0.2.0)\n
Importing tag 0.2.0 (0.2.0.0)\n
Reading composer.json of repman-io/repman (0.2.1)\n
Importing tag 0.2.1 (0.2.1.0)\n
Reading composer.json of repman-io/repman (0.3.0)\n
Importing tag 0.3.0 (0.3.0.0)\n
Reading composer.json of repman-io/repman (0.4.0)\n
Importing tag 0.4.0 (0.4.0.0)\n
Reading composer.json of repman-io/repman (0.4.1)\n
Importing tag 0.4.1 (0.4.1.0)\n
Reading composer.json of repman-io/repman (0.5.0)\n
Importing tag 0.5.0 (0.5.0.0)\n
Reading composer.json of repman-io/repman (0.6.0)\n
Importing tag 0.6.0 (0.6.0.0)\n
Reading composer.json of repman-io/repman (1.0.0)\n
Importing tag 1.0.0 (1.0.0.0)\n
Reading composer.json of repman-io/repman (1.1.0)\n
Importing tag 1.1.0 (1.1.0.0)\n
Reading composer.json of repman-io/repman (1.1.1)\n
Importing tag 1.1.1 (1.1.1.0)\n
Reading composer.json of repman-io/repman (1.2.0)\n
Importing tag 1.2.0 (1.2.0.0)\n
Reading composer.json of repman-io/repman (1.2.1)\n
Importing tag 1.2.1 (1.2.1.0)\n
Reading composer.json of repman-io/repman (1.2.2)\n
Importing tag 1.2.2 (1.2.2.0)\n
Reading composer.json of repman-io/repman (1.3.0)\n
Importing tag 1.3.0 (1.3.0.0)\n
Reading composer.json of repman-io/repman (1.3.1)\n
Importing tag 1.3.1 (1.3.1.0)\n
Reading composer.json of repman-io/repman (1.3.2)\n
Importing tag 1.3.2 (1.3.2.0)\n
Reading composer.json of repman-io/repman (1.3.3)\n
Importing tag 1.3.3 (1.3.3.0)\n
Reading composer.json of repman-io/repman (1.3.4)\n
Importing tag 1.3.4 (1.3.4.0)\n
Reading composer.json of repman-io/repman (1.3.5)\n
Importing tag 1.3.5 (1.3.5.0)\n
Reading composer.json of repman-io/repman (1.3.6)\n
Importing tag 1.3.6 (1.3.6.0)\n
Reading composer.json of repman-io/repman (feat/php-8.0)\n
Importing branch feat/php-8.0 (dev-feat/php-8.0)\n
Reading composer.json of repman-io/repman (master)\n
Importing branch master (dev-master)\n

Those are clearly the branches and tags of this project, and not, as I expected, the versions of the dists zips in the tests folder. I'll check if the checkout is shallow or something like that

[xvilo]

That was it! I've added the fetch-depth and fetch-tags to the actions/checkout@v3 action. This makes it so the copy isn't (too) shallow. I think it shouldn't fetch itself, so the test might be incorrect. However, I believe this was already the case so I wont address that in this PR.

@marmichalski how you like?

[marmichalski]

That was it! I've added the fetch-depth and fetch-tags to the actions/checkout@v3 action. This makes it so the copy isn't (too) shallow. I think it shouldn't fetch itself, so the test might be incorrect. However, I believe this was already the case so I wont address that in this PR.

@marmichalski how you like?

Can you make the other workflow pass and drop this one, though? 👍
I don't think we should be fetching full history at all times, maybe fetch-tags: true would be enough? Also this does not really explain why the workflow (the one I'd like to keep) is passing on 7.4 and not 8.0

[xvilo]

@marmichalski ah, I've been debugging the wrong file in that case, as that is a different error. I'll restart my investigation with that one

[xvilo]

It might be an issue with git safe directories. I would assume that the 7.4 image might be a bit more outdated then the 8.0 image

[marmichalski]

It might be an issue with git safe directories. I would assume that the 7.4 image might be a bit more outdated then the 8.0 image

Yea, looks to be the case looking at the dubious ownership. Good find 🕵️

[xvilo]

@marmichalski do you have write access to this repository?

[xvilo]

I think it can be merged in to the main branch as is, I don't see any objections right now. We've been using this in prod for a while now through a custom fork

[marmichalski]

I think it can be merged in to the main branch as is, I don't see any objections right now. We've been using this in prod for a while now through a custom fork

Thank you, let's see what happens next 🤞

[xvilo]

I think it can be merged in to the main branch as is, I don't see any objections right now. We've been using this in prod for a while now through a custom fork

Thank you, let's see what happens next 🤞

Do you want me to find some time to work on php 8.2 compatibility, or will you handle this? PR was already open (#660), but with some failing tests that I didn't know enough about

[marmichalski]

Do you want me to find some time to work on php 8.2 compatibility, or will you handle this? PR was already open (#660), but with some failing tests that I didn't know enough about

I can take over that PR in my spare time :)