aliases: strip NULL byte before returning the strings

[ardbiesheuvel]

Resolving aliases doesn't quite work as it should right now, because the
strings contain trailing NULL bytes that don't match the node names. So
ensure that those NULL bytes are stripped.

[repnop]

Hi and thanks for the PR! I'm surprised I haven't hit this myself actually! Only nit is that I think I'd prefer .map(|s| s.trim_end_matches('\0')) in the (very unlikely) case that the value is empty for some reason or someone mistakenly appended an extra null, so as to not panic there.

[ardbiesheuvel]

Hi and thanks for the PR! I'm surprised I haven't hit this myself actually! Only nit is that I think I'd prefer .map(|s| s.trim_end_matches('\0')) in the (very unlikely) case that the value is empty for some reason or someone mistakenly appended an extra null, so as to not panic there.

Sure, but that concern applies equally to the other occurrences of the &pvalue[..p.value.len() - 1] pattern that occur in the same file.

[repnop]

Ah good catch, didn't realize I was doing it in other places as well. I'll merge this then and fix them up in a commit afterwards. Thanks!