Fix setup.py for cases when __pkginfo__.py is absent.

repo-helper · Jan 13, 2022 · e782081 · e782081
1 parent 8164d55
commit e782081
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/repo_helper/templates/setup._py b/repo_helper/templates/setup._py
@@ -12,7 +12,7 @@ from setuptools import setup
 sys.path.append('.')
 
 # this package
-from __pkginfo__ import *  # pylint: disable=wildcard-import
+{% if extras_require %}from __pkginfo__ import *  # pylint: disable=wildcard-import{% endif %}
 
 {% if desktopfile %}
 from textwrap import dedent

diff --git a/tests/test_files/test_packaging.py b/tests/test_files/test_packaging.py
@@ -84,6 +84,7 @@ def test_make_setup_case_1(
 		):
 	demo_environment.globals["desktopfile"] = {}
 	demo_environment.globals["use_whey"] = use_whey
+	demo_environment.globals["extras_require"] = {"foo": ["bar", "baz"]}
 
 	managed_files = make_setup(tmp_pathplus, demo_environment)
 	assert managed_files == ["setup.py"]
@@ -103,6 +104,7 @@ def test_make_setup_case_2(
 		):
 	demo_environment.globals["desktopfile"] = {}
 	demo_environment.globals["use_whey"] = use_whey
+	demo_environment.globals["extras_require"] = {"foo": ["bar", "baz"]}
 
 	demo_environment.globals.update(
 			dict(