Skip to content

Commit

Permalink
Ensure RECORD itself is listed in .dist-info/RECORD
Browse files Browse the repository at this point in the history
  • Loading branch information
domdfcoding committed Mar 22, 2021
1 parent e4c3589 commit 57a2f31
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
12 changes: 12 additions & 0 deletions tests/test_build.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,18 @@ def check_built_wheel(filename: PathPlus, file_regression: FileRegressionFixture
with zip_file.open("whey-2021.0.0.dist-info/METADATA", mode='r') as fp:
check_file_regression(fp.read().decode("UTF-8"), file_regression)

contents = sorted(zip_file.namelist())

with zip_file.open("whey-2021.0.0.dist-info/RECORD", mode='r') as fp:
for line in fp.readlines():
entry_filename, digest, size, *_ = line.decode("UTF-8").strip().split(",")
assert entry_filename in contents, entry_filename
contents.remove(entry_filename)

if "RECORD" not in entry_filename:
assert zip_file.getinfo(entry_filename).file_size == int(size)
# TODO: check digest

return sorted(zip_file.namelist())


Expand Down
4 changes: 4 additions & 0 deletions whey/builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -674,6 +674,10 @@ def create_wheel_archive(self) -> str:
fp.write('\n')
wheel_archive.write(file, arcname=file.relative_to(self.build_dir))

for file in self.dist_info.rglob("RECORD*"):
if file.is_file():
fp.write(f"{file.relative_to(self.build_dir).as_posix()},,\n")

for file in self.dist_info.rglob("RECORD*"):
if file.is_file():
wheel_archive.write(file, arcname=file.relative_to(self.build_dir))
Expand Down

0 comments on commit 57a2f31

Please sign in to comment.