Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Incorrect DESTINATION_REPOSITORY value with release v2.12 #126

Closed
dcrossleyau opened this issue Jan 20, 2023 · 6 comments · Fixed by #127
Closed

Incorrect DESTINATION_REPOSITORY value with release v2.12 #126

dcrossleyau opened this issue Jan 20, 2023 · 6 comments · Fixed by #127

Comments

@dcrossleyau
Copy link

This pull-request action has been working beautifully for us for a long time. Thanks so much.

However today it broke with the v2.12 release.

Our repo is public:
https://github.com/folio-org/folio-org.github.io/actions/workflows/pr-config-apidocs.yml

For today's failed runs, see the "Gather Inputs" section where it has the incorrect value:
DESTINATION_REPOSITORY=folio-org/folio-org
i.e. the organization name instead of the repository name.

See the previous successful run which has the correct value:
DESTINATION_REPOSITORY=folio-org/folio-org.github.io

@wei
Copy link
Member

wei commented Jan 20, 2023

Thanks for the report! For now please use v2.11. We'll fix this soon!

@m4heshd any way you can revise the repo matching to support all valid characters including ._- symbols, etc?

@m4heshd
Copy link
Contributor

m4heshd commented Jan 20, 2023

@wei I'll take a look at it just in a few hours. I was waiting for something to go south after the release. 😆

m4heshd added a commit to m4heshd/pull-request that referenced this issue Jan 21, 2023
m4heshd added a commit to m4heshd/pull-request that referenced this issue Jan 21, 2023
@m4heshd
Copy link
Contributor

m4heshd commented Jan 21, 2023

@dcrossleyau Can you do a test using:

- name: pull-request
  id: open-pr
  uses: m4heshd/pull-request@special-char-fix

@dcrossleyau
Copy link
Author

Hooray, yes that is verified. @m4heshd -- Thanks for your prompt attention.

See successful run.

@wei
Copy link
Member

wei commented Jan 21, 2023

This is now released as repo-sync/pull-request@v2.12.1 and repo-sync/pull-request@v2 🎉

@dcrossleyau
Copy link
Author

Thanks to the responsiveness of all.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants