Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[break] Rename rtd option in generate-rtd to make it configurable #101

Merged
merged 4 commits into from
Nov 29, 2020

Conversation

slarse
Copy link
Collaborator

@slarse slarse commented Nov 29, 2020

Fix #96

This PR renames the generate-rtd --reference-tests-dir option to --junit4-reference-tests-dir to make it configurable. Now it picks up on the junit4_reference_tests_dir option in the config file.

@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

Merging #101 (c0287d5) into master (ff0bfa2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files           8        8           
  Lines         432      432           
  Branches       65       65           
=======================================
  Hits          405      405           
  Misses         16       16           
  Partials       11       11           
Impacted Files Coverage Δ
repobee_junit4/_generate_rtd.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff0bfa2...c0287d5. Read the comment docs.

@slarse slarse merged commit 08984a4 into repobee:master Nov 29, 2020
@slarse slarse deleted the issue/96-rename-rtd-option branch November 29, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent use of argument names: --reference-tests-dir vs --junit4-reference-tests-dir
1 participant