eden/report_portal_client branch PR #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehaelyon
changed the title
ehaelyon
force-pushed
the
eden/report_portal_client
branch
3 times, most recently
from
944d7fc
to
52e7a5b
Compare
ehaelyon
force-pushed
the
eden/report_portal_client
branch
from
52e7a5b
to
32ac5c8
Compare
ehaelyon
force-pushed
the
eden/report_portal_client
branch
4 times, most recently
from
098f06e
to
fc1e870
Compare
- Add the 2 attributes: self.launch_name self.launch_number - Add the method update_launch_name_and_number that updates the 2 attributes above
- Implement the launch_uuid attribute - Save the launch id under the self.launch_id and the uuid under the self.launch_uuid - Replace all usages of launch_id with launch_uuid - Fix the launch creation mechanism, retry creation if launch was not created as properly - convert the _batch_logs to a dict in order to support multiple threads - Add the thread_id to the log signature - Handle the thread_id under the _log_batch
ehaelyon
force-pushed
the
eden/report_portal_client
branch
from
2eb0966
to
5c1111d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.launch_name
self.launch_number
that updates the 2 attributes above when the rp-launch-id
pytest argument is provided