Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPU consumption fix, missed Test Case ID bypass fix #169

Merged
merged 31 commits into from
Mar 15, 2022
Merged

CPU consumption fix, missed Test Case ID bypass fix #169

merged 31 commits into from
Mar 15, 2022

Conversation

HardNorth
Copy link
Member

@HardNorth HardNorth commented Feb 11, 2022 •
edited
Loading

  • CPU consumption fix
  • Test Case ID bypass fix
  • Ability to bypass None status, since it's legal in the latest versions of Report Portal
  • ExternalIssue class btsUrl field name fix
  • Add priority for ControlCommand class

iivanou
iivanou requested changes Feb 11, 2022
View reviewed changes
reportportal_client/core/worker.py Outdated Show resolved Hide resolved
reportportal_client/core/worker.py Outdated Show resolved Hide resolved
reportportal_client/core/worker.py Outdated Show resolved Hide resolved
iivanou
iivanou requested changes Feb 28, 2022
View reviewed changes
Copy link
Collaborator

@iivanou iivanou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not need to add all of this(the commit: Add processing priority), if you leave the previous code where we used the PriorityQueue. The protocol is already implemented here.

@HardNorth HardNorth requested a review from iivanou March 12, 2022 15:17
@iivanou
Copy link
Collaborator

iivanou commented Mar 14, 2022

The rest of the code looks good to me.

@HardNorth HardNorth requested a review from iivanou March 14, 2022 15:31
@HardNorth HardNorth requested a review from iivanou March 14, 2022 16:04
@iivanou iivanou merged commit ae94f52 into master Mar 15, 2022
@iivanou iivanou deleted the cpu-consumption-fix branch March 15, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iivanou iivanou iivanou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HardNorth @iivanou