-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No test logs if TestNG Test has timeout parameter #105
Comments
Yes, that's client issue due to ThreadLocal we use in our logging contexts. I believe we need to redesign it, but not in current (v5) version. |
As a possible solution we can use InheritedThreadLocal for every Thread, except main. This will probably work for TestNG and JUnit5, since the first one is using main thread only for Suite creation and the second one is not using main thread at all. But what if some frameworks use main thread in the same way as other threads? |
@HardNorth is there any progress on this? Perhaps this can be parameterized in the client and defaulted to the existing behavior? and frameworks that need this behavior can update to use this setting to solve this issue. |
@dagansandler not yet, the issue has milestone 6 since it requires serious logging logic rewrite. Currently I'm working on milestone 5.1, which is related to Android compatibility. |
Fixed in #183 |
I faced with no logs in RP when I specify timeout parameter in TestNG Test annotation. All events that are relayed to start/stop/methods reflected fine in RP, but no logging from TestNG test that I send through RP appender.
Here is example of
@Test
annotation@Test(description = "test", dataProvider = "DataProvider", alwaysRun = true, timeout = 60)
in DEBUG MODE
event.getmessage()
has correct message, butin
com.epam.reportportal.service.ReportPortal.emitLog
next variable is nullafter removing timeout parameter all work well
The text was updated successfully, but these errors were encountered: