-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epmrpp 83130 || Update the token generation and its storage #337
Conversation
import java.util.List; | ||
import javax.validation.constraints.NotNull; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary javadoc is missing.
* @author Andrei Piankouski | ||
*/ | ||
@JsonInclude(Include.NON_NULL) | ||
public class ApiKeysRS { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abbreviation in name 'ApiKeysRS' must contain no more than '1' consecutive capital letters.
|
||
@Override | ||
public String toString() { | ||
return "ApiKeysRS{" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'+' should be on a new line.
@Override | ||
public String toString() { | ||
return "ApiKeysRS{" + | ||
"apiKeys=" + apiKeys + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'+' should be on a new line.
import java.util.Date; | ||
import javax.validation.constraints.NotNull; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary javadoc is missing.
import com.fasterxml.jackson.annotation.JsonProperty; | ||
import javax.validation.constraints.NotNull; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First sentence of Javadoc is missing an ending period.
|
||
/** | ||
* Api key representation for responses | ||
* @author Andrei Piankouski |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @author Andrei Piankouski | ||
*/ | ||
@JsonInclude(Include.NON_NULL) | ||
public class ApiKeyRQ { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abbreviation in name 'ApiKeyRQ' must contain no more than '1' consecutive capital letters.
|
||
@Override | ||
public String toString() { | ||
return "ApiKeyRQ{" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'+' should be on a new line.
@Override | ||
public String toString() { | ||
return "ApiKeyRQ{" + | ||
"name='" + name + '\'' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'+' should be on a new line.
import java.util.List; | ||
import javax.validation.constraints.NotNull; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First sentence of Javadoc is missing an ending period.
import java.util.Date; | ||
import javax.validation.constraints.NotNull; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First sentence of Javadoc is missing an ending period.
Kudos, SonarCloud Quality Gate passed!
|
* 5.8.0 || Release version (#336) * EPMRPP-80383 || Notifications. AND/OR attribute option * EPMRPP-80383 || Notifications. Fix dto * EPMRPP-80606 || Increase ItemAttribute key and value max length (#327) EPMRPP-80606 || Increase ItemAttribute key and value max length * EPMRPP-81193 || Wrong error code and message when creating notification rule without mandatory field * EPMRPP-82300-fix-typo-error edited error msg * EPMRPP-78258 || Remove shareable entities (#315) (#333) * EPMRPP-78258 || Remove share flag * EPMRPP-78258 || Update naming Co-authored-by: Pavel Bortnik <pavel_bortnik@epam.com> * Update version * EPMRPP-83280 || Update version --------- Co-authored-by: Andrei Piankouski <andrei_piankouski@epam.com> Co-authored-by: Ivan Kustau <86599591+IvanKustau@users.noreply.github.com> Co-authored-by: miracle8484 <76156909+miracle8484@users.noreply.github.com> Co-authored-by: rkukharenka <ryhor_kukharenka@epam.com> Co-authored-by: rkukharenka <125865748+rkukharenka@users.noreply.github.com> Co-authored-by: Pavel Bortnik <pavel_bortnik@epam.com> * [Gradle Release Plugin] - new version commit: '5.8.1'. * Epmrpp 83130 || Update the token generation and its storage (#337) * EPMRPP-83130 || Update the token generation and its storage * EPMRPP-83130 || update models * EPMRPP-83130 || Replace LocalDate to Date * EPMRPP-83130 || Add java doc --------- Co-authored-by: Andrei Piankouski <andrei_piankouski@epam.com> * EPMRPP-84065 || Change data-time format for created_at field for API Key REST API * EPMRPP-84251 || Fix checkstyle * EPMRPP-84251 || Fix test --------- Co-authored-by: Andrei Piankouski <andrei_piankouski@epam.com> Co-authored-by: Ivan Kustau <86599591+IvanKustau@users.noreply.github.com> Co-authored-by: miracle8484 <76156909+miracle8484@users.noreply.github.com> Co-authored-by: rkukharenka <ryhor_kukharenka@epam.com> Co-authored-by: rkukharenka <125865748+rkukharenka@users.noreply.github.com> Co-authored-by: Pavel Bortnik <pavel_bortnik@epam.com> Co-authored-by: reportportal.io <support@reportportal.io>
No description provided.