Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restoring not working properly for zoom panel #1486

Closed
HCY123902 opened this issue Mar 19, 2021 · 1 comment · Fixed by #1487
Closed

Restoring not working properly for zoom panel #1486

HCY123902 opened this issue Mar 19, 2021 · 1 comment · Fixed by #1487
Assignees
@HCY123902
Labels
c.Bug d.Contributors

Comments

@HCY123902
Copy link
Contributor

HCY123902 commented Mar 19, 2021 •
edited

Tell us about your environment

  • **RepoSense Version:**master
  • **OS and Version:**Windows10
  • **Web Browser and Version (if applicable):**Edge

Please include the steps to reproduce the bug.

  1. Open the zoom panel of an individual author
  2. Merge the group and open the group zoom panel
  3. Reload the page

What was expected to happen?
The zoom panel of the merged group should be shown on the screen

What actually happened? Please include a screenshot of the output.
The zoom panel of an individual author is shown

image

If possible, include the URL to your RepoSense report or log files (if any).
@HCY123902 HCY123902 mentioned this issue Mar 19, 2021
Merged
@gerhean
Copy link
Contributor

gerhean commented Mar 20, 2021

Bug is actually a regression due to #1457 changing only some instances of isMerge to isMerged.

The only real change which needs to be made is to rename all isMerge to isMerged, and:

v_summary_charts.js line 178:
from
zAuthor: user.name,
to
zAuthor: isMerged ? '' : user.name,
which I believe is the reasonable change to make as there should not be an author when the group is merged.

@damithc damithc added this to For contributors in Roadmap Apr 4, 2021
fzdy1914 pushed a commit that referenced this issue Apr 13, 2021
@HCY123902
[#1486] Frontend: rename zIsMerge to zIsMerged (#1487)
57edc43 
The zoom panel of a merged group currently cannot be restored after 
reloading the page. This is caused by incomplete renaming of the 
zIsMerge argument in #1457.

Renaming other instances of zIsMerge can resolve this issue and make 
the reloading behavior more consistent with the user expectation.

Let's change all instances of zIsMerge to zIsMerged.
@dcshzj dcshzj removed this from For contributors in Roadmap Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HCY123902 HCY123902

Labels
c.Bug d.Contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1486] Frontend: rename zIsMerge to zIsMerged HCY123902/RepoSense
3 participants
@damithc @gerhean @HCY123902