Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1377] DG: minor improvement to Setting Up section #1380

Merged

Conversation

rolandyuwy
Copy link
Contributor

@rolandyuwy rolandyuwy commented Dec 17, 2020

Fixes #1377

To allow the setting up process to be more seamless, include a quick tip to find out the version of each prerequisite from the OS terminal.

Proposed commit message:

In the Setting Up section of the Developer Guide,
a hint is provided for checking the version of git,
but not for JDK or npm.

Let's provide hints for JDK and npm as well.

@damithc
Copy link
Collaborator

damithc commented Dec 17, 2020

I think the proposed commit message can be shorter. Something along these lines?

In the .... a hint is provided for x but not for y and z.

Let's provide hints for y and z as well.

Copy link
Contributor

@Tejas2805 Tejas2805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@fzdy1914 fzdy1914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rolandyuwy Can u modify the proposed message as pointed out by Prof?

@rolandyuwy
Copy link
Contributor Author

@rolandyuwy Can u modify the proposed message as pointed out by Prof?

Changes to the proposed message have been made. Thank you!

@fzdy1914 fzdy1914 changed the title [#1377] Minor improvement to consistency and readability of Developer Guide - Setting Up section [#1377] DG: minor improvement to Setting Up section Dec 24, 2020
@fzdy1914 fzdy1914 merged commit 5136d4e into reposense:master Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor improvement to consistency and readability of Developer Guide section
5 participants