Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1284] Adjust the design documentation #1388

Closed

Conversation

HCY123902
Copy link
Contributor

@HCY123902 HCY123902 commented Dec 23, 2020

Resolves #1284
Commit message:

Add the documentation for v_resizer.js and adjust
the documentation of api.js

There seems to be some deviation between the
implementation and documentation of api.js. The
documentation of v_resizer.js also seems to be missing.

Adjusting the existing documentation may make it more
consistent with the current implementation.

Lets's adjust the documentation of api.js and add the
documentation for v_resizer.js.

I did not split this PR into 2 separate ones because the problems mentioned above is included in a single issue.

@Tejas2805
Copy link
Contributor

Not too sure but I think there are changes required in the diagram too if I am correct. @fzdy1914 Your opinion?

@fzdy1914
Copy link
Member

Let's edit this documentation after the whole morphing of frontend code first. It is kind of acceptable now.

@github-actions
Copy link
Contributor

Hi,
We are going to mark this PR as stale because it has been inactive for the past 30 days.
If no further activity occurs within the following 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 7 days and leave a comment to remove the stale label.
Do let us know if you are stuck so that we can help you!'

@github-actions github-actions bot added the Stale label Feb 27, 2021
@HCY123902
Copy link
Contributor Author

Sure, no problem

@github-actions github-actions bot removed the Stale label Feb 28, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2021

Hi,
We are going to mark this PR as stale because it has been inactive for the past 30 days.
If no further activity occurs within the following 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 7 days and leave a comment to remove the stale label.
Do let us know if you are stuck so that we can help you!'

@github-actions github-actions bot added the Stale label May 1, 2021
@HCY123902 HCY123902 force-pushed the branch-report-documentation branch from 2409564 to 1f34def Compare May 1, 2021 03:13
@HCY123902
Copy link
Contributor Author

This pull request is ongoing and it will adapt to the change in implementation

@github-actions github-actions bot removed the Stale label May 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2021

Hi,
We are going to mark this PR as stale because it has been inactive for the past 30 days.
If no further activity occurs within the following 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 7 days and leave a comment to remove the stale label.
Do let us know if you are stuck so that we can help you!'

@github-actions github-actions bot added the Stale label Jun 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2021

This PR was closed because it has been marked as stale for 7 days with no activity.
Feel free to reopen this PR if you would like to continue working on it.

@github-actions github-actions bot closed this Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update design documentation
3 participants