-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1407] DG: add Gradle instructions to workflow #1408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One nit.
docs/dg/workflow.md
Outdated
@@ -28,7 +28,7 @@ Our workflow is mostly based on the guidelines given at se-education.org/guides. | |||
* Make sure you know our coding standards. | |||
{{ embed('Appendix: Coding Standards', 'styleGuides.md', level=2) }} | |||
* **Follow [this](https://se-education.org/guides/tutorials/intellijCodeStyle.html) to configure Intellij to follow our coding style**. | |||
* **This project uses Checkstyle** to check the compliance of Java code. You can use [this document](https://se-education.org/guides/tutorials/checkstyle.html) to find how to use it. | |||
* **This project uses Checkstyle** to check the compliance of Java code. You can use [this document](https://se-education.org/guides/tutorials/checkstyle.html) to find how to use it. In Particular, run `gradlew checkstyleMain checkstyleTest checkstyleSystemtest` to check the style of all the relevant Java code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* **This project uses Checkstyle** to check the compliance of Java code. You can use [this document](https://se-education.org/guides/tutorials/checkstyle.html) to find how to use it. In Particular, run `gradlew checkstyleMain checkstyleTest checkstyleSystemtest` to check the style of all the relevant Java code. | |
* **This project uses Checkstyle** to check the compliance of Java code. You can use [this document](https://se-education.org/guides/tutorials/checkstyle.html) to find how to use it. In particular, run `gradlew checkstyleMain checkstyleTest checkstyleSystemtest` to check the style of all the relevant Java code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing it out. I have edited it.
@dcshzj Any idea why the deployment is failing here? |
The deployment code itself works, but I think the issue was that there were multiple instances of it running. The surge.sh deployment cannot perfectly pinpoint the exact workflow run to download the artifacts for. One way is to not trigger too many CI runs within a short time frame. If deployment fails again, we can just trigger it again by closing and reopening the PR. |
Can you try to look into a fix for it? As it is affecting our normal usage. Instead of uploading artifacts into one position. Is modifying the path or name helping, different repo have a different paths? Just look into it first. |
@dcshzj And since I will be merging this PR, you may open an issue to keep the discussion. |
Resolves #1407
Commit message: