Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1429] Make GitHub Actions workflows more specific for artifacts #1434

Merged
merged 10 commits into from
Jan 25, 2021
Merged

[#1429] Make GitHub Actions workflows more specific for artifacts #1434

merged 10 commits into from
Jan 25, 2021

Conversation

dcshzj
Copy link
Member

@dcshzj dcshzj commented Jan 25, 2021 •
edited

Fixes #1429.

Currently, GitHub Actions can encounter race conditions where
multiple pull requests are deployed at once, causing confusion as
to the exact artifacts to download. This is caused by not
specifying the pull request numbers when downloading artifacts.

Let's make it such that the correct artifacts are downloaded even
when multiple deployments occur concurrently.

Testing pull requests:

@dcshzj
Make GitHub Actions workflows more specific for artifacts
1a7fe08
@dcshzj
Set workflow job step to run for pull requests only
dda1d0e
@dcshzj
Make GitHub Actions workflows more specific for artifacts
72f6d90 
Currently, GitHub Actions can encounter race conditions where
multiple pull requests are deployed at once, causing confusion as
to the exact artifacts to download. This is caused by not
specifying the pull request numbers when downloading artifacts.

Let's make it such that the correct artifacts are downloaded even
when multiple deployments occur concurrently.
@dcshzj dcshzj marked this pull request as draft January 25, 2021 13:18
@github-actions github-actions bot temporarily deployed to dashboard January 25, 2021 13:18 Inactive
@github-actions github-actions bot temporarily deployed to docs January 25, 2021 13:18 Inactive
@github-actions github-actions bot temporarily deployed to dashboard January 25, 2021 13:38 Inactive
@github-actions github-actions bot temporarily deployed to docs January 25, 2021 13:38 Inactive
@github-actions github-actions bot requested a deployment to dashboard January 25, 2021 13:41 Abandoned
@github-actions github-actions bot requested a deployment to docs January 25, 2021 13:41 Abandoned
@github-actions github-actions bot temporarily deployed to dashboard January 25, 2021 13:54 Inactive
@github-actions github-actions bot temporarily deployed to docs January 25, 2021 13:54 Inactive
@dcshzj dcshzj marked this pull request as ready for review January 25, 2021 14:07
@dcshzj dcshzj requested a review from a team January 25, 2021 14:08
fzdy1914
fzdy1914 approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@fzdy1914 fzdy1914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fzdy1914 fzdy1914 merged commit 99a4a3d into reposense:master Jan 25, 2021
@dcshzj dcshzj deleted the 1429-actions-deployments-conflict branch January 25, 2021 16:32
@raysonkoh raysonkoh mentioned this pull request Feb 24, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzdy1914 fzdy1914 fzdy1914 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub Actions conflict if multiple deployments are done in a short amount of time
2 participants
@dcshzj @fzdy1914