Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1426] Zoom reloading not function properly #1437

Merged

Conversation

gerhean
Copy link
Contributor

@gerhean gerhean commented Jan 29, 2021

When following the steps mentioned in #1426,
we get an error.

The error is caused by the zFilterSearch parameter of the url
being the string 'undefined', which causes restoreZoomFiltered
in v_summary.js to crash as 'isMatchSearchedUser(zFilterSearch, user)'
does not match any user leading to an array index out of bounds error.

Lets fix this by ensuring that zFilterSearch is defined in v_ramp, 
such that zFilterSearch='undefined' is not generated in the url,
when one clicks on the ramp.

This does not fix the fact that a bad url can still cause the error.

@gerhean gerhean requested a review from a team January 29, 2021 07:24
Copy link
Contributor

@0blivious 0blivious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please write a complete PR message, including what causes the error and the explanation for your solution. Then you can ask review from stage2

@gerhean gerhean requested a review from a team January 31, 2021 05:20
@fzdy1914
Copy link
Member

fzdy1914 commented Feb 7, 2021

@gerhean Just a question, as mentioned in your commit message, a bad URL can still cause an error. How do you define a bad URL? Can we ignore such parameters if they are provided?

@gerhean
Copy link
Contributor Author

gerhean commented Feb 7, 2021

@fzdy1914
I would define a bad URL as a URL which would cause the reposense website to crash, even if the URL cannot possibly be generated by the website itself.
Example of bad URL: go to any reposense, look for &sort=groupTitle in the url and change it to &sort=a, on refresh it will completely not work.

@fzdy1914
Copy link
Member

fzdy1914 commented Feb 8, 2021

@fzdy1914
I would define a bad URL as a URL which would cause the reposense website to crash, even if the URL cannot possibly be generated by the website itself.
Example of bad URL: go to any reposense, look for &sort=groupTitle in the url and change it to &sort=a, on refresh it will completely not work.

Seems that this can be solved easily by a pre-verification step? Can you put it as an issue to solve such invalid parameters?

@fzdy1914 fzdy1914 merged commit 7b8dd64 into reposense:master Feb 22, 2021
@gerhean gerhean deleted the Zoom-reloading-not-function-properly-#1426 branch March 29, 2021 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants