Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1464] Remove group highlight when merging group #1466

Merged
merged 6 commits into from
Apr 2, 2021
Merged

[#1464] Remove group highlight when merging group #1466

merged 6 commits into from
Apr 2, 2021

Conversation

HCY123902
Copy link
Contributor

Resolves #1464

Commit message:

Remove group highlight in summary view when the tab
is not on the merged group

Currently, a merged group will be highlighted in the summary
view even if the tab is not on the merged group but a member of
the group.

Removing the group highlight in this situation can make the 
highlight provide more accurate information.

Let's remove the group highlight when merging a group.

@HCY123902 HCY123902 changed the title [#1464] Remove group highlight when merging or expanding group [#1464] Remove group highlight when merging group Mar 7, 2021
@HCY123902 HCY123902 requested a review from a team March 7, 2021 14:47
gerhean
gerhean approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@gerhean gerhean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HCY123902 HCY123902 requested review from a team and removed request for a team March 19, 2021 03:28
@fzdy1914 fzdy1914 merged commit 8e93f28 into reposense:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerhean gerhean gerhean approved these changes

@fzdy1914 fzdy1914 fzdy1914 approved these changes

@0blivious 0blivious 0blivious approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect highlighting after merging/unmerging groups
4 participants
@HCY123902 @gerhean @fzdy1914 @0blivious