Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1476] Remove the highlighting when the panel is closed #1480

Merged
merged 10 commits into from
Apr 22, 2021
Merged

[#1476] Remove the highlighting when the panel is closed #1480

merged 10 commits into from
Apr 22, 2021

Conversation

HCY123902
Copy link
Contributor

@HCY123902 HCY123902 commented Mar 15, 2021 •
edited

Resolves #1476

Commit message:

Remove highlighting when the panel is closed by the user

The highlighting of the selected tab on the summary 
view is present when the panel is closed.

Removing the highlighting will make the indicated tab 
information more consistent.

Let's remove the highlighting when closing the panel

@HCY123902 HCY123902 changed the title Remove the highlighting when the panel is closed [#1476] Remove the highlighting when the panel is closed Mar 15, 2021
@HCY123902 HCY123902 requested a review from a team March 15, 2021 05:16
gerhean
gerhean approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@gerhean gerhean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HCY123902 HCY123902 requested a review from a team March 19, 2021 03:26
0blivious
0blivious reviewed Mar 19, 2021
View reviewed changes
frontend/src/static/js/store.js
@@ -8,6 +8,7 @@ const store = new Vuex.Store({
fileTypeColors: {},
loadingOverlayCount: 0,
loadingOverlayMessage: '',
isTabActive: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this set to false by default?

Copy link
Contributor Author

@HCY123902 HCY123902 Mar 19, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing it out. Currently, isTabActive is set to true by default in the main window during its initialization to show the resizer. It is after a tab is selected and then closed that isTabActive will be set to false, so I set isTabActive to be true in the store initially.

@0blivious 0blivious requested a review from fzdy1914 March 20, 2021 04:39
@HCY123902 HCY123902 requested a review from a team March 23, 2021 06:10
fzdy1914
fzdy1914 requested changes Mar 29, 2021
View reviewed changes
frontend/src/static/js/main.js Outdated
@@ -112,14 +112,15 @@ window.app = new window.Vue({

this.isTabActive = true;
this.tabType = tabName;

this.$store.commit('updateTabState', this.isTabActive);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the tab state in Vuex is always the same with this.isTabActive. We can just remove this.isTabActive and use the one in Vuex.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, no problem

@fzdy1914 fzdy1914 requested a review from gerhean March 30, 2021 12:42
@fzdy1914
Copy link
Member

The highlighting of the selected tab on the summary view is present
even when the panel is closed.

Removing the highlighting will make the indicated tab information
more consistent.

Let's remove the highlighting when closing the panel.

@fzdy1914 fzdy1914 merged commit ec76074 into reposense:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzdy1914 fzdy1914 fzdy1914 approved these changes

@0blivious 0blivious 0blivious approved these changes

@gerhean gerhean Awaiting requested review from gerhean

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Highlighting persists even when tab closed.
4 participants
@HCY123902 @fzdy1914 @gerhean @0blivious