Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade minimatch version #1511

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

gerhean
Copy link
Contributor

@gerhean gerhean commented Mar 29, 2021

Regression by #1482,

minimatch@1.0.0 is deprecated and is causing some problems.

Lets upgrade to minimatch@3.0.4.

@gerhean gerhean requested a review from fzdy1914 March 29, 2021 10:16
@dcshzj
Copy link
Member

dcshzj commented Mar 31, 2021

Are we able to continue using jsDelivr instead? Using skypack is a deviation from what we have been using previously.

https://cdn.jsdelivr.net/npm/minimatch@3.0.4

@gerhean
Copy link
Contributor Author

gerhean commented Mar 31, 2021

So skypack is I think the easiest way to use ES6 modules in the current project.

First understand that there are two types of js modules, CommonJS and ES6 modules. ES6 modules are originally made for nodejs, but since some of them are useful and have no CommonJS alternatives like minimatch, we run into some problems where the browser doesn't support some functions of ES6 modules.

So in order to mitigate this issue, people use js module bundlers like browsersify, which I removed because it was kinda not being maintained properly (https://github.com/vuejs/vueify).

Skypack is just an easy plug and forget thing so naturally I used it.

image
I think this sums it up nicely. @dcshzj

@dcshzj
Copy link
Member

dcshzj commented Mar 31, 2021

I see, thanks for the summary! No other comments from me.

@fzdy1914 fzdy1914 merged commit 9d78bc0 into reposense:master Mar 31, 2021
fzdy1914 pushed a commit that referenced this pull request Mar 31, 2021
minimatch@1.0.0 is deprecated and will cause potential vulnerability.

Let's upgrade it to minimatch@3.0.4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants