-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1234] Move relevant test cases in ArgsParserTest to RepoSenseTest class #1530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't agree that we should move them to a separate class, but I leave it for the seniors to give their inputs.
Also, do assign the tasks to yourselves if you are intending to work on it, or if you have already submitted a PR. This makes the issue tracker easier to navigate.
Judging by the name and the aspects to be tested, I feel we should still assign them to ArgParser class. @fzdy1914 @Tejas2805 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A majority of the testing involves the ArgsParserClass, therefore don't think this migration is necessary. @fzdy1914 your opinion?
Agree that it is trivial to do so. I would like to better classify it as ArgsParserTest also. |
Resolves #1234
Commit message: