Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1630] Rearrange Gradle tasks and their dependencies #1631

Merged
merged 23 commits into from
Apr 11, 2022
Merged
Changes from 22 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
ab60526
Merge branch 'master' of https://github.com/reposense/RepoSense
yhtMinceraft1010X Aug 26, 2021
1f3cb05
Merge branch 'master' of https://github.com/reposense/RepoSense
yhtMinceraft1010X Sep 24, 2021
4142873
Merge branch 'master' of https://github.com/reposense/RepoSense
yhtMinceraft1010X Dec 23, 2021
6ba4885
Merge branch 'master' of https://github.com/reposense/RepoSense
yhtMinceraft1010X Jan 19, 2022
5403b80
Merge branch 'master' of https://github.com/reposense/RepoSense
yhtMinceraft1010X Jan 22, 2022
0e488bd
Remove frontend dependency for backend tests
yhtMinceraft1010X Jan 25, 2022
037a561
Fix cypress not running automatically
yhtMinceraft1010X Jan 25, 2022
9a3121c
Fix NullPointerException for zipReport
yhtMinceraft1010X Jan 25, 2022
d7542fd
Fix systemtests
yhtMinceraft1010X Jan 26, 2022
7d5c248
Merge branch 'master' into 1630-improve-gradle
yhtMinceraft1010X Feb 19, 2022
24aa665
Merge branch 'master' into 1630-improve-gradle
yhtMinceraft1010X Feb 21, 2022
ea2927e
Merge branch 'master' into 1630-improve-gradle
yhtMinceraft1010X Feb 24, 2022
3b46dae
Merge branch 'master' into 1630-improve-gradle
yhtMinceraft1010X Mar 1, 2022
49f6e56
Merge branch 'master' into 1630-improve-gradle
yhtMinceraft1010X Mar 13, 2022
d9d9abb
Update task dependencies
yhtMinceraft1010X Mar 13, 2022
c75a416
Rename startServerInBackground
yhtMinceraft1010X Mar 14, 2022
815d232
Remove zipReport from CI
yhtMinceraft1010X Mar 14, 2022
40ba0d5
Merge branch 'master' into 1630-improve-gradle
yhtMinceraft1010X Mar 23, 2022
06c0dc9
Merge branch 'master' into 1630-improve-gradle
yhtMinceraft1010X Mar 25, 2022
4f88fc7
Consolidate executionData
yhtMinceraft1010X Mar 27, 2022
732d0b6
Merge branch 'master' into 1630-improve-gradle
yhtMinceraft1010X Mar 27, 2022
ef6687b
Merge branch 'master' into 1630-improve-gradle
gerhean Mar 30, 2022
905d3f1
Merge branch 'master' into 1630-improve-gradle
dcshzj Apr 10, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 49 additions & 48 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,32 @@ wrapper {
gradleVersion = '6.9.2'
}

def installFrontend = tasks.register('installFrontend', com.liferay.gradle.plugins.node.tasks.ExecutePackageManagerTask) {
workingDir 'frontend/'
args = ['install']
}

def buildFrontend = tasks.register('buildFrontend', com.liferay.gradle.plugins.node.tasks.ExecutePackageManagerTask) {
dependsOn installFrontend
workingDir 'frontend/'
args = ['run', 'devbuild']
}

def zipReport = tasks.register('zipReport', Zip) {
dependsOn buildFrontend
from 'frontend/build/'
archiveBaseName = 'templateZip'
destinationDirectory = file('src/main/resources')
}

def compileJava = tasks.compileJava
def classes = tasks.classes

tasks.run.dependsOn(zipReport);

run {
//the second arguments indicates the default value associated with the property.
tasks.compileJava.mustRunAfter(zipReport)
args System.getProperty('args', '').split()
systemProperty "version", getRepoSenseVersion()
}
Expand All @@ -74,19 +98,6 @@ idea {
}
}

jacoco {
toolVersion = "0.8.7"
}

jacocoTestReport {
reports {
html.enabled = true
xml.enabled true
csv.enabled false
html.destination file("${buildDir}/jacocoHtml")
}
}

test {
environment("REPOSENSE_ENVIRONMENT", "TEST")

Expand All @@ -106,7 +117,10 @@ test {
}
}

tasks.shadowJar.dependsOn(zipReport);

shadowJar {
tasks.compileJava.mustRunAfter(zipReport)
archiveFileName = 'RepoSense.jar'
destinationDirectory = file("${buildDir}/jar/")

Expand All @@ -115,31 +129,12 @@ shadowJar {
}
}

def installFrontend = tasks.register('installFrontend', com.liferay.gradle.plugins.node.tasks.ExecutePackageManagerTask) {
workingDir 'frontend/'
args = ['install']
}

def buildFrontend = tasks.register('buildFrontend', com.liferay.gradle.plugins.node.tasks.ExecutePackageManagerTask) {
dependsOn installFrontend
workingDir 'frontend/'
args = ['run', 'devbuild']
}

tasks.register('lintFrontend', com.liferay.gradle.plugins.node.tasks.ExecutePackageManagerTask) {
dependsOn installFrontend
workingDir 'frontend/'
args = ['run', 'lint']
}

def zipReport = tasks.register('zipReport', Zip) {
dependsOn buildFrontend
from 'frontend/build/'
archiveBaseName = 'templateZip'
destinationDirectory = file('src/main/resources')
}

def compileJava = tasks.compileJava
def checkstyleMain = tasks.checkstyleMain
def checkstyleTest = tasks.checkstyleTest
def checkstyleSystemtest = tasks.checkstyleSystemtest
Expand All @@ -150,12 +145,7 @@ tasks.register('checkstyleAll', Checkstyle) {
tasks.checkstyleSystemtest.mustRunAfter('checkstyleTest')
}

tasks.shadowJar.dependsOn(zipReport);
tasks.compileJava.dependsOn(zipReport);
tasks.run.dependsOn(compileJava);

tasks.register('systemtest', Test) {
dependsOn zipReport
testClassesDirs = sourceSets.systemtest.output.classesDirs
classpath = sourceSets.systemtest.runtimeClasspath
environment("REPOSENSE_ENVIRONMENT", "TEST")
Expand All @@ -176,10 +166,9 @@ tasks.register('systemtest', Test) {
}
}

def classes = tasks.classes

def startServerInBackground = tasks.register('startServerInBackground', com.github.psxpaul.task.JavaExecFork) {
dependsOn classes
def serveTestReportInBackground = tasks.register('serveTestReportInBackground', com.github.psxpaul.task.JavaExecFork) {
dependsOn zipReport, compileJava, classes
tasks.compileJava.mustRunAfter(zipReport)
main = mainClassName
classpath = sourceSets.main.runtimeClasspath
args = ['--config', './frontend/cypress/config', '--since', 'd1', '--view']
Expand All @@ -194,16 +183,16 @@ def installCypress = tasks.register('installCypress', com.liferay.gradle.plugins
}

tasks.register('cypress', com.liferay.gradle.plugins.node.tasks.ExecutePackageManagerTask) {
dependsOn zipReport, installCypress, startServerInBackground
tasks.startServerInBackground.mustRunAfter(installCypress)
dependsOn installCypress, serveTestReportInBackground
tasks.serveTestReportInBackground.mustRunAfter(installCypress)

workingDir = file('frontend/cypress/')
args = ["run-script", "debug"]
}

tasks.register('frontendTest', com.liferay.gradle.plugins.node.tasks.ExecutePackageManagerTask) {
dependsOn zipReport, installCypress, startServerInBackground
tasks.startServerInBackground.mustRunAfter(installCypress)
dependsOn installCypress, serveTestReportInBackground
tasks.serveTestReportInBackground.mustRunAfter(installCypress)

workingDir = file('frontend/cypress/')
args = ["run-script", "tests"]
Expand All @@ -218,6 +207,21 @@ tasks.withType(Copy) {
includeEmptyDirs = true
}

jacoco {
toolVersion = "0.8.7"
}

jacocoTestReport {
reports {
html.enabled = true
xml.enabled true
csv.enabled false
html.destination file("${buildDir}/jacocoHtml")
}

executionData systemtest, frontendTest
}

tasks.register('coverage', JacocoReport)

coverage.configure {
Expand Down Expand Up @@ -291,7 +295,4 @@ void deleteReposAddressDirectory() {
reposDirectory.deleteDir()
}

jacocoTestReport.executionData(systemtest)
jacocoTestReport.executionData(frontendTest)

defaultTasks 'clean', 'build', 'systemtest', 'frontendTest', 'coverage'