-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Gradle to 6.9.2 #1664
Upgrade Gradle to 6.9.2 #1664
Conversation
I've requested a second run of the checks. It seems the previous build failed on this |
Might be a concurrency issue similar to #1601. I think we should wait for #1625 to be merged. |
A third-party plugin has a property that requires Java 9 to work properly. It throws an error when Java 8 is used. Let's downgrade it to a version before this property was introduced.
A pre-compiled Java 8 jar file works on Java 17. Let's reverse the ug change implying that Java 17 cannot work.
The register method defers configuration of tasks such that tasks are only configured when needed. Let's use the register method.
The .with methods in CSVFormat are marked for deprecation in v1.9.0 of Apache Commons CSV. Let's switch to the builder methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The current implementation seems to work well. Just some minor comments/clarifications.
Would like to confirm if rewriting the task definitions as tasks.register(...)
is to support a future gradle 7 upgrade described here since it seems the gradle 6.8.2 documentation uses quite a different syntax.
Additionally, would it be possible to assign the tasks to variables to avoid referencing them by string? More details are described in the specific comment.
build.gradle
Outdated
|
||
manifest { | ||
attributes 'Implementation-Version': getRepoSenseVersion() | ||
} | ||
} | ||
|
||
task installFrontend(type: com.liferay.gradle.plugins.node.tasks.ExecuteNpmTask) { | ||
tasks.register('installFrontend', com.liferay.gradle.plugins.node.tasks.ExecutePackageManagerTask) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For those curious like me, it seems the task name itself was changed in this commit liferay/liferay-portal@e47fedf.
build.gradle
Outdated
tasks.register('installFrontend', com.liferay.gradle.plugins.node.tasks.ExecutePackageManagerTask) { | ||
workingDir 'frontend/' | ||
args = ['install'] | ||
} | ||
|
||
task buildFrontend(dependsOn: ['installFrontend'], type: com.liferay.gradle.plugins.node.tasks.ExecuteNpmTask) { | ||
tasks.register('buildFrontend', com.liferay.gradle.plugins.node.tasks.ExecutePackageManagerTask) { | ||
dependsOn 'installFrontend' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to do an assignment like def installFrontend = tasks.register(...)
? This way all further references to installFrontend
like in line 120 can reference installFrontend
without quotations directly. At least this seems possible when I tried it locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I managed to change some of the assignments
For |
May I ask about the significance of including the |
@gerhean I think the Apache License terms requires that the copyright notice is retained. I think for the "the original author or authors", we should leave it as it is, in case of licensing issues that may occur. |
Just want to confirm that this has been tested to work on Windows? I assume it works on MacOs and Linux since the CI passed. |
@gerhean Yep, I pulled the branch, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The following links are for previewing this pull request:
|
Part of #1661. Upgrading to version
6.9.2
is meant to be a stopgap measure while resolving errors from third-party plugins.Propsed Commit Message: