Upgrade Gradle to 6.9.2 #1664

yhtMinceraft1010X · 2022-02-13T15:06:50Z

Part of #1661. Upgrading to version 6.9.2 is meant to be a stopgap measure while resolving errors from third-party plugins.

Propsed Commit Message:

Gradle has been stuck at 5.2.1 for quite some time. This version is not
compatible with a future migration to Java 17. However, upgrading to
Gradle 7.4 cannot be done yet due to a need to resolve errors from
third-party plugins.

Let's upgrade Gradle to 6.9.2 in the meantime to close the gap between
the version we are using and the latest available version.

This reverts commit d49d882.

This reverts commit e2eeaed.

Gradle 6.9.2 contains changes backported from 7.0, including Log4J vulnerability mitigations. Let's move to 6.9.2 as an interim measure.

chan-j-d · 2022-02-13T15:49:35Z

I've requested a second run of the checks. It seems the previous build failed on this
https://github.com/reposense/RepoSense/runs/5174576252?check_suite_focus=true#step:11:1465.
I've encountered it myself a few times and it's always somewhat random, perhaps we should raise a separate issue about it.

yhtMinceraft1010X · 2022-02-13T16:47:30Z

I've requested a second run of the checks. It seems the previous build failed on this https://github.com/reposense/RepoSense/runs/5174576252?check_suite_focus=true#step:11:1465. I've encountered it myself a few times and it's always somewhat random, perhaps we should raise a separate issue about it.

Might be a concurrency issue similar to #1601. I think we should wait for #1625 to be merged.

A third-party plugin has a property that requires Java 9 to work properly. It throws an error when Java 8 is used. Let's downgrade it to a version before this property was introduced.

A pre-compiled Java 8 jar file works on Java 17. Let's reverse the ug change implying that Java 17 cannot work.

The register method defers configuration of tasks such that tasks are only configured when needed. Let's use the register method.

The .with methods in CSVFormat are marked for deprecation in v1.9.0 of Apache Commons CSV. Let's switch to the builder methods.

chan-j-d

LGTM! The current implementation seems to work well. Just some minor comments/clarifications.

Would like to confirm if rewriting the task definitions as tasks.register(...) is to support a future gradle 7 upgrade described here since it seems the gradle 6.8.2 documentation uses quite a different syntax.
Additionally, would it be possible to assign the tasks to variables to avoid referencing them by string? More details are described in the specific comment.

chan-j-d · 2022-03-14T05:52:37Z

build.gradle


    manifest {
        attributes 'Implementation-Version': getRepoSenseVersion()
    }
 }

-task installFrontend(type: com.liferay.gradle.plugins.node.tasks.ExecuteNpmTask) {
+tasks.register('installFrontend', com.liferay.gradle.plugins.node.tasks.ExecutePackageManagerTask) {


For those curious like me, it seems the task name itself was changed in this commit liferay/liferay-portal@e47fedf.

chan-j-d · 2022-03-14T06:16:16Z

build.gradle

+tasks.register('installFrontend', com.liferay.gradle.plugins.node.tasks.ExecutePackageManagerTask) {
    workingDir 'frontend/'
    args = ['install']
 }

-task buildFrontend(dependsOn: ['installFrontend'], type: com.liferay.gradle.plugins.node.tasks.ExecuteNpmTask) {
+tasks.register('buildFrontend', com.liferay.gradle.plugins.node.tasks.ExecutePackageManagerTask) {
+    dependsOn 'installFrontend'


Would it be possible to do an assignment like def installFrontend = tasks.register(...)? This way all further references to installFrontend like in line 120 can reference installFrontend without quotations directly. At least this seems possible when I tried it locally.

I managed to change some of the assignments

yhtMinceraft1010X · 2022-03-14T10:59:07Z

For tasks.register(...), it's used for task configuration avoidance. This prevents unnecessary tasks from being configured, which is best paired with #1631 - when only backend tests or backend checkstyle are run, configuration of frontend-related tasks like installFrontend is not carried out.

gerhean · 2022-03-15T11:00:10Z

May I ask about the significance of including the Apache License block of text? It's a little weird that it Copyright 2015 the original author or authors. but nowhere states who these author or authors are.

dcshzj · 2022-03-15T11:05:48Z

May I ask about the significance of including the Apache License block of text? It's a little weird that it Copyright 2015 the original author or authors. but nowhere states who these author or authors are.

@gerhean I think the Apache License terms requires that the copyright notice is retained. I think for the "the original author or authors", we should leave it as it is, in case of licensing issues that may occur.

gerhean · 2022-03-18T14:30:27Z

Just want to confirm that this has been tested to work on Windows? I assume it works on MacOs and Linux since the CI passed.

chan-j-d · 2022-03-18T14:45:15Z

Just want to confirm that this has been tested to work on Windows? I assume it works on MacOs and Linux since the CI passed.

@gerhean Yep, I pulled the branch, clean build, frontendTest and ran it against a few repositories on Windows when I tested it.

gerhean

LGTM

github-actions · 2022-03-23T05:08:00Z

The following links are for previewing this pull request:

Dashboard Preview: https://dashboard-1664-pr-reposense-reposense.surge.sh
Docs Preview: https://docs-1664-pr-reposense-reposense.surge.sh

yhtMinceraft1010X added 15 commits August 27, 2021 07:51

Merge branch 'master' of https://github.com/reposense/RepoSense

ab60526

Merge branch 'master' of https://github.com/reposense/RepoSense

1f3cb05

Merge branch 'master' of https://github.com/reposense/RepoSense

4142873

Merge branch 'master' of https://github.com/reposense/RepoSense

6ba4885

Merge branch 'master' of https://github.com/reposense/RepoSense

5403b80

Merge branch 'master' of https://github.com/reposense/RepoSense

61e0a92

Merge branch 'master' of https://github.com/reposense/RepoSense

8b80cdb

Merge branch 'master' of https://github.com/reposense/RepoSense

62dc6e1

Merge branch 'master' of https://github.com/reposense/RepoSense

3d1f4ed

Upgrade gradlew to 7.4

e2eeaed

Update build.gradle wrapper

d49d882

Revert "Update build.gradle wrapper"

933dc70

This reverts commit d49d882.

Revert "Upgrade gradlew to 7.4"

edb7593

This reverts commit e2eeaed.

Upgrade Gradle to version 6.9

0b93706

Upgrade to Gradle 6.9.2

a8c69d2

Gradle 6.9.2 contains changes backported from 7.0, including Log4J vulnerability mitigations. Let's move to 6.9.2 as an interim measure.

yhtMinceraft1010X requested review from a team February 13, 2022 15:07

dcshzj added the s.ToReview label Feb 13, 2022

Fix wrapper typo

d708db4

Update Java version in docs

73585a4

dcshzj removed the request for review from a team February 14, 2022 00:30

yhtMinceraft1010X added 2 commits February 14, 2022 09:49

Replace deprecated properties

0e29602

Downgrade third-party plugin

e72f812

A third-party plugin has a property that requires Java 9 to work properly. It throws an error when Java 8 is used. Let's downgrade it to a version before this property was introduced.

chan-j-d mentioned this pull request Feb 15, 2022

Concurrency Overhaul for RepoSense #1669

Closed

yhtMinceraft1010X added 4 commits February 16, 2022 18:18

Merge branch 'master' of https://github.com/reposense/RepoSense

f08cba4

Merge branch 'master' into 1661-upgrade-gradle

2410d8f

Merge branch 'master' into 1661-upgrade-gradle

62859f3

Merge branch 'master' into 1661-upgrade-gradle

97e31fb

yhtMinceraft1010X added 7 commits February 24, 2022 12:17

Merge branch 'master' into 1661-upgrade-gradle

1ecea1f

Reverse user guide change

b63fb3e

A pre-compiled Java 8 jar file works on Java 17. Let's reverse the ug change implying that Java 17 cannot work.

Merge branch 'master' into 1661-upgrade-gradle

6ea8f3b

Use tasks.register

5c0b7f4

The register method defers configuration of tasks such that tasks are only configured when needed. Let's use the register method.

Upgrade dependencies

aab63e4

Revert Node version

76fee24

Use CSVFormat.Builder

57ac6a8

The .with methods in CSVFormat are marked for deprecation in v1.9.0 of Apache Commons CSV. Let's switch to the builder methods.

chan-j-d approved these changes Mar 14, 2022

View reviewed changes

Reduce string literals

bfa3e2a

chan-j-d requested a review from a team March 14, 2022 11:09

gerhean mentioned this pull request Mar 18, 2022

Use liferay node for hotreload #1719

Closed

gerhean approved these changes Mar 18, 2022

View reviewed changes

gerhean added s.FinalReview and removed s.ToReview labels Mar 18, 2022

gerhean requested a review from a team March 18, 2022 14:47

fzdy1914 approved these changes Mar 20, 2022

View reviewed changes

dcshzj added s.ToMerge and removed s.FinalReview labels Mar 23, 2022

Merge branch 'master' into 1661-upgrade-gradle

2e6f523

dcshzj merged commit af551f3 into reposense:master Mar 23, 2022

yhtMinceraft1010X mentioned this pull request Mar 24, 2022

Update User Guide Java Version #1635

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Gradle to 6.9.2 #1664

Upgrade Gradle to 6.9.2 #1664

yhtMinceraft1010X commented Feb 13, 2022 •

edited by dcshzj

Loading

chan-j-d commented Feb 13, 2022 •

edited

Loading

yhtMinceraft1010X commented Feb 13, 2022

chan-j-d left a comment

chan-j-d Mar 14, 2022

chan-j-d Mar 14, 2022

yhtMinceraft1010X Mar 14, 2022

yhtMinceraft1010X commented Mar 14, 2022

gerhean commented Mar 15, 2022

dcshzj commented Mar 15, 2022

gerhean commented Mar 18, 2022 •

edited

Loading

chan-j-d commented Mar 18, 2022 •

edited

Loading

gerhean left a comment

github-actions bot commented Mar 23, 2022

Upgrade Gradle to 6.9.2 #1664

Upgrade Gradle to 6.9.2 #1664

Conversation

yhtMinceraft1010X commented Feb 13, 2022 • edited by dcshzj Loading

chan-j-d commented Feb 13, 2022 • edited Loading

yhtMinceraft1010X commented Feb 13, 2022

chan-j-d left a comment

Choose a reason for hiding this comment

chan-j-d Mar 14, 2022

Choose a reason for hiding this comment

chan-j-d Mar 14, 2022

Choose a reason for hiding this comment

yhtMinceraft1010X Mar 14, 2022

Choose a reason for hiding this comment

yhtMinceraft1010X commented Mar 14, 2022

gerhean commented Mar 15, 2022

dcshzj commented Mar 15, 2022

gerhean commented Mar 18, 2022 • edited Loading

chan-j-d commented Mar 18, 2022 • edited Loading

gerhean left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 23, 2022

yhtMinceraft1010X commented Feb 13, 2022 •

edited by dcshzj

Loading

chan-j-d commented Feb 13, 2022 •

edited

Loading

gerhean commented Mar 18, 2022 •

edited

Loading

chan-j-d commented Mar 18, 2022 •

edited

Loading