-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1771] Add tip on generating report via reposense-action #1858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. I personally think this is a quite helpful change. The only concern that I have is that when a user generates a report in this way, it can overwrite others' reports for the same repository. Let's ask for professor Damith's thoughts about it since this is related to user experience
Could you explain what you mean by that?
I am not sure I understand the given scenario to provide clarifications.
Sure. |
Oh I was referring to the first scenario that you mentioned. However, I do not think this is really a significant issue as long as the users coordinated with each other. |
@tlylt thanks for this idea and the implementation. Yes, I think it would be nice to have this option for users. |
Hi @damithc, I was proposing either documentation or adopting the repo. I'm fine with either. Since there wasn't a clear decision from the RepoSense team in #1771, I am proposing this documentation PR for visibility. |
Personally I think we should adopt the repo since it sounds like a good direction to take RepoSense in. |
Yes, I think moving this action into the RepoSense GitHub organization would be good as well. @tlylt are you okay with initiating the transfer of the repository to |
Sure I can add an MIT license to it. I think I can request a transfer to the reposense org, just not too sure how to deal with the part where this action is already published on the marketplace. Not sure if that affects anything. Do you happen to know anything about that @dcshzj? If not I guess we can make the transfer and figure it out along the way. |
I'm not entire sure about the publishing to the actions marketplace part, but I think it should be okay to initiate the transfer first and figure out if there are any issues that arise. Otherwise, we can un-publish the release for the action and re-publish it once the transfer is completed. |
Hi @dcshzj, I will need the temporary access here: https://docs.github.com/en/repositories/creating-and-managing-repositories/transferring-a-repository#repository-transfers-and-organizations |
@tlylt I have just invited you, please try again. I will remove you once the transfer is complete. |
Thanks, @dcshzj, think there are a few things to be sorted out for changing links/references, etc. This PR should still be gd to go tho. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think in the future, we should move the documentation for the GitHub action into the user guide so that it is all in a single place, but this is sufficient for now.
The following links are for previewing this pull request:
|
Fixes #1771
Proposed commit message
Other information
To manually test reposense-action, follow the instructions in the README
The action itself contains a test with the generated report published on GitHub Pages and surge.sh
Real-life usage (by myself) can also be seen in this yaml and the generated site