Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#968] Enforce Vue option order #1867

Merged
merged 8 commits into from Jan 31, 2023
Merged

[#968] Enforce Vue option order #1867

merged 8 commits into from Jan 31, 2023

Conversation

vvidday
Copy link
Contributor

@vvidday vvidday commented Jan 23, 2023 •
edited by dcshzj

Fixes #968

Proposed commit message

Currently, the order of component options is not enforced, resulting in
inconsistent ordering across files. Although there is a rule in the
ESLint Vue plugin that enforces this, it is currently being omitted.

Let's enable the order-in-components rule to enforce a consistent order
of component options according to the recommended order in the Vue style
guide.

This will improve the consistency and readability of the code.

Other information

In addition to the option order rule, there's the require-prop-types rule that is still being ignored. It was however resolved in #1852 and can now be removed to enforce prop types in the future - please advise if I should include it here or open another PR to remove it. Thanks!

@vvidday vvidday marked this pull request as ready for review January 23, 2023 14:33
@vvidday vvidday requested a review from a team January 23, 2023 14:34
ckcherry23
ckcherry23 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

HCY123902
HCY123902 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@HCY123902 HCY123902 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I think you should remove require-prop-types in a separate pull request

@HCY123902 HCY123902 requested a review from a team January 23, 2023 15:54
yhtMinceraft1010X
yhtMinceraft1010X approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@yhtMinceraft1010X yhtMinceraft1010X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcshzj dcshzj merged commit c162ff2 into reposense:master Jan 31, 2023
@github-actions
Copy link
Contributor

The following links are for previewing this pull request:

@vvidday vvidday mentioned this pull request Feb 1, 2023
Merged
@vvidday vvidday mentioned this pull request Mar 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HCY123902 HCY123902 HCY123902 approved these changes

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@yhtMinceraft1010X yhtMinceraft1010X yhtMinceraft1010X approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enforce Vue option order
5 participants
@vvidday @HCY123902 @ckcherry23 @yhtMinceraft1010X @dcshzj