update message on per commit view #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since you're at it, fix my the other comment too, |
eugenepeh
reviewed
Jan 29, 2019
frontend/src/index.jade
Outdated
| @@ -110,11 +110,12 @@ html | |||
| v-for="(commit, k) in slice.commitResults", | |||
| v-if="commit.insertions>0", | |||
| v-bind:title="`[${slice.date}] ${commit.message}: ${commit.insertions} lines`", | |||
| v-bind:class="'summary-chart__ramp__slice--color'+j%5", | |||
| v-bind:class="'summary-chart__ramp__slice--color' + j%5", | |||
yamidark
reviewed
Jan 30, 2019
frontend/src/index.jade
Outdated
| }" | ||
| ) | ||
|
|
||
| template(v-else) | ||
| a.summary-chart__ramp__slice( | ||
| v-for="(slice, j) in user.commits", | ||
| v-if="slice.insertions>0", | ||
| v-bind:title="`contribution on ${slice.date}: ${slice.insertions} lines`", | ||
| v-bind:title="`[${slice.date}] ${filterTimeFrame==='day' ? 'Daily' : 'Weekly'} contribution: ${slice.insertions} lines`", |
There was a problem hiding this comment.
Space around the === operator as well?
frontend/src/static/js/v_summary.js
Outdated
| @@ -132,7 +132,7 @@ window.vSummary = { | |||
| const newSize = 100 * (slice.insertions / this.avgCommitSize); | |||
| return Math.max(newSize * this.rampSize, 0.5); | |||
| }, | |||
| getSlicePos(i, total){ | |||
| getSlicePos(i, total) { | |||
| return (total-i-1) / total; | |||
There was a problem hiding this comment.
The - operators here as well
eugenepeh
reviewed
Jan 30, 2019
eugenepeh
approved these changes
Jan 31, 2019
frontend/src/index.jade
Outdated
| zIndex: user.commits.length - j,\ | ||
| borderLeftWidth: getWidth(commit) + 'em',\ | ||
| right: ((getSlicePos(j, user.commits.length)\ | ||
| + (getSlicePos(k, slice.commitResults.length) / user.commits.length)) * 100) + '%'\ |
There was a problem hiding this comment.
here should be double indent too.
yamidark
approved these changes
Jan 31, 2019
There was a problem hiding this comment.
@eugenepeh May need to update Codacy, seems to have some conflicts with our ESLint settings
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in response to comment on #500