RampChart: add group by authors option

[chel-seyy]

Fixes #543.

Users are only allowed to group the ramp charts by repository.

While grouping by repository allows users to have a rough comparison of
contributions between authors of the same repository, it does not
provide any insight into an author's contribution data across all
repositories he has contributed to.

Let's add the grouping of authors as an option for users to select, and
this can work towards the goal of having a toolbar[1] at the top of the
report.

[1]: Sorting options graphical goal:
https://github.com/orgs/reposense/teams/devs/discussions/1

[fzdy1914]

From my part, the way to choose which to group is a little bit weird.

Can consider to make it a drop-down choice just like sort by option. It is just a suggestion anyway. Maybe you can ask prof for his option.

[chel-seyy]

Hmm I see, but sorting of the ramp charts is done in the select-menu, where the user can sort by author name, contribution etc. So changing this to sort by may be confusing.
@damithc your opinion on this?

[damithc]

Hmm I see, but sorting of the ramp charts is done in the select-menu, where the user can sort by author name, contribution etc. So changing this to sort by may be confusing.
@damithc your opinion on this?

I think he meant that we can use a drop-down instead of radio buttons, to follow the style of sort by.

[damithc]

At one point we mentioned about aiming for something like this. So, it does make sense to make it a drop-down.

[fzdy1914]

I think he meant that we can use a drop-down instead of radio buttons, to follow the style of sort by.

@chelseyong Sorry for not explaining clearly. Using a drop-down is what I mean.

[fzdy1914]

Maybe it is better to put group by section before sort by section?
So the order makes more sense.

[eugenepeh]

Another interesting bug, notice how the display name has changed according to the reverse checkbox.

[chel-seyy]

Hmm.. interesting indeed.
For these 2 repositories, despite both having the same username, they have different display name.
When the order is reversed, since the code takes the first repository's display name, the author's name will now be different.

However, the situation that 2 similar users have different display name but same username is quite rare.
One possible alternative is to display the username beside the author (in brackets) to reduce user's confusion. Eg: Eugene (eugenepeh)

[chel-seyy]

codacy kept failing.. The logic for updateSortSelection seems simple though.

[yamidark]

codacy kept failing.. The logic for updateSortSelection seems simple though.

If you are unable to resolve this Codacy issue, we can just ignore it for now, not much of an issue.

[eugenepeh]

However, the situation that 2 similar users have different display name but same username is quite rare.
One possible alternative is to display the username beside the author (in brackets) to reduce user's confusion. Eg: Eugene (eugenepeh)

Yes, that's a good way to resolve this problem.

[chel-seyy]

@eugenepeh thanks! Can this be merged soon to proceed with #601?

[damithc]

Nice 👍

[ongspxm]

minor nits

[ongspxm]

comment that this is making everything "under one group", not apparent on first glance

[yamidark]

Nits to proposed message:

Currently, Users are only allowed to group the ramp charts by repository.

While grouping by repository allows users to have a rough comparison of contributions
between authors of the same repository, it does not provide any
They are not able to group them by authors, which can provide greater insight
into an author's contribution data, across all repositories he has contributed to.

Let's add the grouping of authors as an option for users to select, and this can
work towards the goal of having a toolbar[1] at the top of the dashboardreport.

[1]: Sorting toolbar for referenceSorting options graphical goal:
https://github.com/orgs/reposense/teams/devs/discussions/1