[#581] CodeView#filter: add interactive selection switch

[fzdy1914]

Fixes #581

The filter selection's radio button serves nothing more than an "indicator".
Changing option doesn't do anything until the corresponding controls are
modified.

It is redundant and inconvenient for users to manually switch the selection.

Instead of disabling the deselected option, let's allow interaction switch
the selection.

[chel-seyy]

Perhaps the indicated selection (i.e. radio button) can update when the user presses but have not entered anything into the filter box. This can provide more user feedback by showing that the selection has changed.

[fzdy1914]

Perhaps the indicated selection (i.e. radio button) can update when the user presses but have not entered anything into the filter box. This can provide more user feedback by showing that the selection has changed.

Have edited it as request.

[chel-seyy]

I notice the filter box is not "disabled" (looks grey) after switching. Is it intended this way?

[fzdy1914]

I notice the filter box is not "disabled" (looks grey) after switching. Is it intended this way?

It should be the intended behavior mentioned in #581 .

[damithc]

hmm... after playing around with the feature, it feels like the previous state was more intuitive although it takes an extra click. What do you guys think?
Perhaps we should allow both ways of switching between the two modes?

[fzdy1914]

hmm... after playing around with the feature, it feels like the previous state was more intuitive although it takes an extra click. What do you guys think?
Perhaps we should allow both ways of switching between the two modes?

@eugenepeh @yamidark @yong24s Your opinions on this?

[eugenepeh]

@eugenepeh @yamidark @yong24s Your opinions on this?

Sounds good to me

[yamidark]

@eugenepeh @yamidark @yong24s Your opinions on this?

Sounds good to me as well

[fzdy1914]

@damithc I have changed as request, please review the latest commit.

[damithc]

Looks good 👍

[ongspxm]

minor nits

[codecov]

Codecov Report

Merging #608 into master will decrease coverage by 0.41%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #608      +/-   ##
============================================
- Coverage     80.64%   80.22%   -0.42%     
+ Complexity      537      522      -15     
============================================
  Files            68       68              
  Lines          1767     1745      -22     
  Branches        185      179       -6     
============================================
- Hits           1425     1400      -25     
- Misses          247      251       +4     
+ Partials         95       94       -1

Impacted Files	Coverage Δ	Complexity Δ
...ain/java/reposense/parser/RepoConfigCsvParser.java	84.21% <0%> (-5.45%)	5% <0%> (-3%)
...c/main/java/reposense/model/RepoConfiguration.java	81.81% <0%> (-3.9%)	58% <0%> (-8%)
src/main/java/reposense/parser/CsvParser.java	67.56% <0%> (-0.73%)	15% <0%> (-4%)
...main/java/reposense/model/AuthorConfiguration.java	85.05% <0%> (+0.53%)	29% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c25cfd...b08199c. Read the comment docs.