Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only some labels are actually applied to the repository #259

Open
gdude2002 opened this issue Jun 8, 2020 · 11 comments
Open

Only some labels are actually applied to the repository #259

gdude2002 opened this issue Jun 8, 2020 · 11 comments
Labels

Comments

@gdude2002
Copy link

Problem Description

For whatever reason, given a set of labels in the settings.yml, they don't all seem to be created together within a repository.

What is actually happening

We have 14 labels defined. However, only 11 of them are created the first time around. It seems that the labels that aren't created are the first three - Duplicate, Good First Issue and Invalid.

If the settings.yml (referred to like this, for example) is updated, then the rest of the labels are created.

Please note that I've manually created the missing labels in these repositories.

What is the expected behaviour

All labels should be created together when the settings.yml is put in place.

Context

Are you using the hosted instance of probot/settings or running your own?

I'm using the hosted instance.

@gdude2002 gdude2002 added the bug label Jun 8, 2020
@stale
Copy link

stale bot commented Sep 6, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Sep 6, 2020
@stocky37
Copy link

stocky37 commented Sep 9, 2020

FWIW, I'm seeing the same thing.

@stale stale bot removed the wontfix label Sep 9, 2020
@travi
Copy link
Member

travi commented Sep 9, 2020

finding time to investigate some of these details has been difficult for me lately. if someone is able to dig deep enough to understand why this is happening, it would be a big help for moving this forward. if i were to take a guess, it likely is related to pagination. a PR would be a huge help, if someone is willing to go that far.

@stocky37
Copy link

stocky37 commented Sep 9, 2020

I might be able to make some time over the weekend to do what I can.

@stocky37
Copy link

stocky37 commented Sep 9, 2020

It looks like I had two separate issues:

  • If the label description is longer than the limit it will be skipped
  • Color field not surrounded by quotes, with aleading digit (with alpha chars - e.g. color: 5aaaaa) would fail in different ways - sometimes not applying, sometimes applying with no color

@stale
Copy link

stale bot commented Dec 25, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Dec 25, 2020
@Josee9988
Copy link

Same here :(

@stale stale bot removed the wontfix label Apr 17, 2021
@SVendittelli
Copy link

SVendittelli commented Aug 31, 2021

I am getting this issue too

Edit: I found my labels were not being applied for two reasons:

  1. I had emoji in the descriptions. GitHub only allows unicode characters less than 0xffff which rules out a lot of emojis. Not all though. I solved this by removing the emoji.
  2. Some colors were numbers with leading zeros which did not get applied. I solved this by putting all colors in quotes.

Un1matr1x added a commit to Just-Another-Weather-Site/playground that referenced this issue Jul 25, 2022
@mdelapenya
Copy link

Still seeing this. Playing with the default settings.yml file:

Pushing this file:

labels:
  - name: "type/bug"
    color: '#CC0000'
    description: An issue with the system 🐛.

  - name: "type/feature"
    # If including a `#`, make sure to wrap it with quotes!
    color: '#336699'
    description: New functionality.

  - name: "Help Wanted"
    # Provide a new name to rename an existing label
    new_name: first-timers-only

Generates only two labels: Help Wanted and type/feature. type/bug is never created

I pushed changes to the yaml file (label names without quoted):

labels:
  - name: type/bug
    color: '#CC0000'
    description: An issue with the system 🐛.

  - name: type/feature
    # If including a `#`, make sure to wrap it with quotes!
    color: '#336699'
    description: New functionality.

  - name: Help Wanted
    # Provide a new name to rename an existing label
    new_name: first-timers-only

And it generated two different labels for the help wanted:

Screenshot 2022-09-15 at 09 59 29

The one for bugs never appeared.

I can observe that with every push, the label with new_name is alternatively passing from first-times-only to Help wanted and viceversa.

travi added a commit that referenced this issue Sep 20, 2022
and added an integration test for configuring labels

for #145, for #259
travi added a commit that referenced this issue Sep 20, 2022
and added an integration test for configuring labels

for #145, for #259
@MAN-Sendance
Copy link

MAN-Sendance commented Jul 3, 2023

It is still a significant issue.

It seems that the bot cannot add more than 40 labels.

@MAN-Sendance
Copy link

It is still a significant issue.

It seems that the bot cannot add more than 40 labels.

In fact, it was my fault. I didn't recognize that description is limited to 100 characters which are why only the labels with a valid length of description have been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants