fix: octokit.repos.replaceTopics is now octokit.repos.replaceAllTopics
#386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absolutely agree and this is my intent with the integration tests that i've slowly been getting added, but i admittedly dont have integration coverage of all flows yet. thank you for getting these updated. i'll use this as motivation to get coverage in place for at least these sometime soon |
travi
added a commit
to travi/settings
that referenced
this pull request
Dec 15, 2020
…efined based on lacking coverage that could have prevented some of the changes needed in repository-settings#386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should try to cover more code with integration tests without mocking methods that no longer exist @travi
I went through the unit tests and compared the mocks to the changelogs at https://github.com/octokit/plugin-rest-endpoint-methods.js/releases/v4.0.0, I think we should be good now