Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java libs #60

Merged
merged 3 commits into from Jan 31, 2021
Merged

Update java libs #60

merged 3 commits into from Jan 31, 2021

Conversation

bartkamphorst
Copy link
Contributor

@dometto This PR updates the bundled Java libs and resolves #53. The issue there was that UsernamePasswordCredentialsProvider could not (or no longer) be called with password being nil (null). Have a look and let me know if the current fix is okay with you.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0002%) to 99.434% when pulling 49e0dd3 on update_java_libs into 29dba7a on master.

Copy link
Contributor

@dometto dometto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bartkamphorst bartkamphorst merged commit 9848699 into master Jan 31, 2021
@bartkamphorst bartkamphorst deleted the update_java_libs branch January 31, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to find org.eclipse.jgit.transport.UsernamePasswordCredentialsProvider
3 participants