New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new version Sphinx 4.0 requires this package to be updated #16
Comments
It is a bit hard to understand the Sphinx documentation, but I interpret
as |
Your interpretation is correct. Rendered to HTML: https://www.sphinx-doc.org/en/master/extdev/deprecated.html |
Here's the PR and explanation for the deprecation. |
What do we want to do? Drop Python 2 support? Pin to Sphinx < 4 or vendor in |
I'd suggest to drop Python 2 support, it should make the code cleaner here. |
Also see #13 - the problem was well known for years. |
pinging @jamadden who - at least for other packages - wanted to keep Python 2 support for some more time |
I see no need to still build the documentation of a package on Python 2. |
Agreed. Sphinx itself dropped support for running on Python 2 some time ago, and projects that support Python 2 also support Python 3 (and so can build their docs with Python 3). So as long as the metadata ( |
#14 was a PR that's been merged which partly fixed this issue when it was originally reported in #13. But there were some issues with that, and according to the comments on #14, @tseaver and @freddrake were going to take a look at things. So master is in a different state than the released plugin and in fact may already have unintentionally dropped support for Python 2. |
What should be the supported versions of Python going forward? I'd suggest 3.6+, dropping all earlier EOLed versions. I would also suggest bringing in @tseaver's preferences from #14. I'd be happy to do the necessary work. Are there any other items that should be included, such as adding GitHub Actions for CI? |
CI is still on travis-ci.org, so it should work for now (besides from being very slow). It would be nice to migrate to GHA but having a released version has more value to me. |
Travis announced to finally shut down travis-ci.org at the end of May - this time for sure :-) |
I gave it a shot, but I quickly got in way over my head. I'd be happy to work with someone who knows this library and is willing to be a mentor to me and fix it. Please Here's a short list of things that I think need to be upgraded:
|
@stevepiercy That is completely relatable - when I noticed this package was broken, I also tried... but one fixed problem led to the next, and without some serious Sphinx knowledge, there was no way to go further. 🤞 somebody with some deeper knowledge and some spare time steps up. |
I opened PR #17 to get this started. I am happy to collaborate with anyone to resolve it, granting access to push commits to my GitHub fork. It's only some housecleaning at the moment. |
I am seeing a similar error when trying to use: Python packages installed:
api.rst
Terminal: ➜ make html Extension error: |
@LauraKirby thanks for the post. I found an open issue that you can track as well. I hope to see someone smarter than I who can fix it, and I can follow their lead. |
Thank you @stevepiercy! |
To provide support for repoze.sphinx.autointerface We can upgrade back once below issue resolves - repoze/repoze.sphinx.autointerface#16 Signed-off-by: odidev <odidev@puresoftware.com>
To provide support for repoze.sphinx.autointerface We can upgrade back once below issue resolves - repoze/repoze.sphinx.autointerface#16 Signed-off-by: odidev <odidev@puresoftware.com>
Just tested 2.4 with sphinx 4.1.2 + /usr/bin/python3 setup.py build_sphinx -b man --build-dir build/sphinx
running build_sphinx
Running Sphinx v4.1.2
running test
WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.
running egg_info
writing repoze.who.egg-info/PKG-INFO
writing dependency_links to repoze.who.egg-info/dependency_links.txt
writing entry points to repoze.who.egg-info/entry_points.txt
writing namespace_packages to repoze.who.egg-info/namespace_packages.txt
writing requirements to repoze.who.egg-info/requires.txt
writing top-level names to repoze.who.egg-info/top_level.txt
reading manifest file 'repoze.who.egg-info/SOURCES.txt'
writing manifest file 'repoze.who.egg-info/SOURCES.txt'
running build_ext
..............................................................................................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 302 tests in 0.047s
OK
making output directory... done
building [mo]: targets for 0 po files that are out of date
building [man]: all manpages
updating environment: [new config] 8 added, 0 changed, 0 removed
reading sources... [100%] use_cases
/home/tkloczko/rpmbuild/BUILD/repoze.who-2.4/docs/configuration.rst:138: WARNING: Unknown interpreted text role "method".
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
writing... python-repoze.who.3 { narr use_cases middleware api configuration plugins changes } done
build succeeded, 1 warning. |
5.0.0b1 of Sphinx again no longer contains |
Fixed by #17 , version 1.0.0 is now published on PyPI. |
@dataflake Thank you very much! |
Also, tox does not work currently.
This package currently only supports Python 2.7 and 3.5.
Also, a couple of hours ago Sphinx 4.0 came out with breaks this package.
The text was updated successfully, but these errors were encountered: