Allow multiple posts with different paths in a resource #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,7 +10,13 @@ def decorated_routes | |||
|
|
|||
| def all_routes | |||
| routes = subclasses.flat_map { |s| s.send(:prepare_routes) } | |||
| routes.uniq(&:options) | |||
| routes.uniq do |r| | |||
There was a problem hiding this comment.
What do you think of implementing a method on the route that returns the attributes that make it unique? In this case it's the route options + the path. Something like this:
class DecoratedRoute
attr_reader :unique_key
def initialize(route)
# setting other instance variables
@unique_key = route_options.merge(path: route.path)
end
endThen we can shorten lines 13-19 to routes.uniq(&:unique_key). What do you think?
|
@njd5475 Hi, this bug is fixed in the current master branch. There were some other things I wanted to change so I couldn't merge your PR, but I mentioned you in the commit and I'm really thankful for your help! |
|
@reprah Thanks for the mention, all good stuff, keep it up! 😁 P.S. Sorry about not responding sooner been busy lately! |
|
@njd5475 No worries, thank you again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path prefix, suffix doesn't seem to be part of the options hash in grape routes only the namespace which does not allow for multiple post routes.