adds a couple of datasets to skip_datasets #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 14, 2021
ocefpaf
reviewed
Jun 18, 2021
erddap_app/plots.py
Outdated
| @@ -47,7 +47,7 @@ def search_datasets(e, standard_name, cdm_data_type, min_time, max_time, skip_da | |||
| continue | |||
|
|
|||
| except HTTPError: | |||
| df = [] | |||
| pass | |||
There was a problem hiding this comment.
It this fails do we have a DataFrame to return below? Returning an empty list is not OK but maybe we should return an empty df or None. Not sure how this function is used down the pipeline to check if this makes sense.
There was a problem hiding this comment.
You were right. It was working in some instances, but I made new changes to the PR that make it more correct and more readable. Let me know what you think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds UNH_CML and UNH_WBD to skip_datasets - see issues #34 and #31 .