Implement keep_old_files option

README.md

@@ -71,6 +71,7 @@ MiniPaperclip.config.tap do |config|
   config.s3_acl           # s3 object acl
   config.s3_cache_control # Set this value to Cache-Control header when put-object
   config.interpolates     # minimum templates using by `String#gsub!`
+  config.keep_old_files   # Delete old attached file if it's false (default false)
   config.read_timeout     # timeout when attachment set url
   config.logger           # You can set logger object.
 end

lib/mini_paperclip.rb

@@ -34,6 +34,7 @@ def config
         },
         hash_data: ":class/:attachment/:id/:style/:updated_at",
         url_missing_path: ":attachment/:style/missing.png",
+        keep_old_files: false,
         read_timeout: 60,
         logger: Logger.new($stdout),
       )

lib/mini_paperclip/attachment.rb

@@ -61,6 +61,10 @@ def assign(file)
       @waiting_write_file = nil
       @meta_content_type = nil
 
+      if present?
+        push_delete_files
+      end
+
       if file.nil?
         assign_nil
       elsif file.instance_of?(Attachment)
@@ -116,6 +120,12 @@ def process_and_store
             @storage.write(style, temp)
           end
         end
+
+        # should delete after write for copy
+        if !@config.keep_old_files
+          do_delete_files
+        end
+
       ensure
         if @waiting_write_file.respond_to?(:close!)
           @waiting_write_file.close!

lib/mini_paperclip/class_methods.rb

@@ -8,7 +8,7 @@ def has_attached_file(attachment_name, option_config = {})
           instance_variable_set("@#{attachment_name}", Attachment.new(self, attachment_name, option_config))
       end
       define_method("#{attachment_name}=") do |file|
-        a = Attachment.new(self, attachment_name, option_config)
+        a = public_send(attachment_name)
         a.assign(file)
         instance_variable_set("@#{attachment_name}", a)
       end

lib/mini_paperclip/config.rb

@@ -16,6 +16,7 @@ class Config < Struct.new(
     :s3_acl,
     :s3_cache_control,
     :interpolates,
+    :keep_old_files,
     :read_timeout,
     :logger,
     keyword_init: true,

lib/mini_paperclip/storage/filesystem.rb

@@ -27,6 +27,7 @@ def push_delete_file(style)
       end
 
       def do_delete_files
+        return if @deletes.empty?
         debug("deleting by filesystem #{@deletes}")
         FileUtils.rm_f(@deletes)
       end

lib/mini_paperclip/storage/s3.rb

@@ -39,6 +39,7 @@ def push_delete_file(style)
       end
 
       def do_delete_files
+        return if @deletes.empty?
         debug("deleting by S3 to bucket:#{@config.s3_bucket_name},objects:#{@deletes}")
         Aws::S3::Client.new.delete_objects(
           bucket: @config.s3_bucket_name,

spec/mini_paperclip/class_methods_spec.rb

@@ -16,7 +16,7 @@
   end
 
   it "should success to save and delete files on s3" do
-    original_config = MiniPaperclip.config
+    original_config = MiniPaperclip.config.dup
     MiniPaperclip.config.storage = :s3
     MiniPaperclip.config.s3_bucket_name = 'test'
 

spec/mini_paperclip/storage/base_spec.rb

@@ -3,22 +3,22 @@
 
   it "#path_for with missing file" do
     attachment = MiniPaperclip::Attachment.new(record, :image)
-    config = MiniPaperclip.config
+    config = MiniPaperclip.config.dup
     base = MiniPaperclip::Storage::Base.new(attachment, config)
     expect(base.path_for(:original)).to eq('images/original/missing.png')
   end
 
   it "#path_for with empty file" do
     attachment = MiniPaperclip::Attachment.new(record, :image)
-    config = MiniPaperclip.config
+    config = MiniPaperclip.config.dup
     base = MiniPaperclip::Storage::Base.new(attachment, config)
     record.image_file_name = ""
     expect(base.path_for(:original)).to eq('records/images/25a80ba6aa8c48f17ea32fc7935fab633e807238.')
   end
 
   it "#path_for with file" do
     attachment = MiniPaperclip::Attachment.new(record, :image)
-    config = MiniPaperclip.config
+    config = MiniPaperclip.config.dup
     base = MiniPaperclip::Storage::Base.new(attachment, config)
     record.image_file_name = "test.png"
     expect(base.path_for(:original)).to eq('records/images/25a80ba6aa8c48f17ea32fc7935fab633e807238.png')

spec/mini_paperclip_spec.rb

@@ -2,6 +2,34 @@
   let(:record) { Record.new }
 
   describe "#config" do
+    it "#keep_old_files = false" do
+      old_file = Rack::Test::UploadedFile.new "spec/paperclip.jpg", 'image/jpeg'
+      record.image.config.keep_old_files = false
+      record.image = old_file
+      record.save!
+      old_file_path = record.image.storage.file_path(:original)
+
+      expect(File.exists?(old_file_path)).to eq(true)
+      new_file = Rack::Test::UploadedFile.new "spec/opaopa.gif", 'image/gif'
+      record.image = new_file
+      record.save!
+      expect(File.exists?(old_file_path)).to eq(false)
+    end
+
+    it "#keep_old_files = true" do
+      old_file = Rack::Test::UploadedFile.new "spec/paperclip.jpg", 'image/jpeg'
+      record.image.config.keep_old_files = true
+      record.image = old_file
+      record.save!
+      old_file_path = record.image.storage.file_path(:original)
+
+      expect(File.exists?(old_file_path)).to eq(true)
+      new_file = Rack::Test::UploadedFile.new "spec/opaopa.gif", 'image/gif'
+      record.image = new_file
+      record.save!
+      expect(File.exists?(old_file_path)).to eq(true)
+    end
+
     it "#hash_data" do
       default_hash_data = MiniPaperclip.config.hash_data
       interpolated_hash_data = record.image.storage.interpolator.interpolate(default_hash_data, :original)