Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OME Tests #91

Merged
merged 3 commits into from
Sep 5, 2018
Merged

OME Tests #91

merged 3 commits into from
Sep 5, 2018

Conversation

jazg
Copy link
Contributor

@jazg jazg commented Sep 4, 2018

Description

Fixed tests for the OME by adding a minimumSettleVolume to the Settler. This allows us to customise the mock Settler used throughout the tests.

Motivation

Issues when testing Settler since the minimum volume was implemented.

@jazg jazg requested a review from tok-kkk September 4, 2018 06:10
@jazg jazg self-assigned this Sep 4, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3593

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 326 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.8%) to 66.787%

Files with Coverage Reduction New Missed Lines %
order/fragment.go 3 68.32%
stream/stream.go 7 90.67%
identity/multiaddress.go 7 78.15%
grpc/conn.go 8 48.98%
stream/channel.go 10 89.0%
grpc/oracle.go 18 75.86%
smpc/message.go 19 30.91%
orderbook/orderbook.go 27 80.0%
grpc/orderbook.go 29 75.63%
grpc/swarm.go 38 73.26%
Totals Coverage Status
Change from base Build 3574: 0.8%
Covered Lines: 4806
Relevant Lines: 7196

💛 - Coveralls

@tok-kkk tok-kkk merged commit 5846c97 into nightly Sep 5, 2018
@tok-kkk tok-kkk deleted the ome-tests branch September 5, 2018 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants