Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android upload (WIP) #97

Merged
merged 10 commits into from
Jul 20, 2018
Merged

Android upload (WIP) #97

merged 10 commits into from
Jul 20, 2018

Conversation

diegomura
Copy link
Contributor

@diegomura diegomura commented Jul 18, 2018

Screenshot
kapture 2018-07-18 at 16 58 19

Todo:

  • Handle page reload when return from finder
  • Update state user info (for updating the header for example)
  • Refactor JS classes a little bit
  • Document Java code
  • Test app overall features in physical device

Fixes #62

@diegomura
Copy link
Contributor Author

@patte all native and JS code done. Hope you liked the changes!

Since this change extends native Webview's functionalities (critical component in the project), the last point I think it would be nice is to check app overall functionality in a physical device. I tested it extensively on the emulator and everything worked perfectly, but still.

@diegomura diegomura changed the base branch from app-notifications to master July 19, 2018 14:32
@diegomura
Copy link
Contributor Author

Going to merge this and release a new version to testing today.
I think this is something we can test on physical devices using this new test version

@diegomura diegomura merged commit 77e03df into master Jul 20, 2018
@diegomura diegomura deleted the android-upload branch July 20, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant