Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mail): allow setting of mailer identifying name #5363

Merged
merged 9 commits into from Jun 11, 2022

Conversation

davwheat
Copy link
Contributor

@davwheat davwheat commented Jun 3, 2022

This is my first contribution to this project. Sorry if I've missed out some steps (please go easy on me!).


The name attribute for nodemailer allows the mailer to provide an optional identifying hostname to the SMTP server.

This is required for Google Workspace users wanting to use Google's Gmail SMTP relay service. Without this, Google will immediately reject the connection to its SMTP server with a very helpful message referring to denial of service.

image

Ref: https://community.nodebb.org/post/81300

I'm not sure where to submit English translations -- hopefully someone can point me in the right direction! 馃

I intend for something like the following:

smtpName: SMTP identifying hostname
smtpNameHint: An optional name to send to the SMTP server to identify your mailer. For Google Workspace customers, this should be your main domain name.

@auto-assign auto-assign bot requested a review from NGPixel June 3, 2022 02:35
@NGPixel
Copy link
Member

NGPixel commented Jun 11, 2022

Great first PR! Thanks!

I'll add the 2 strings to Lokalise.

@NGPixel NGPixel merged commit 97a7445 into requarks:main Jun 11, 2022
@davwheat davwheat deleted the dw/mailer-name branch June 11, 2022 03:31
@davwheat
Copy link
Contributor Author

Thanks! 馃槃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants