Fix page cursor and pagination #5541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
I originally opened the same request on a now deleted account, and will submit pull requests from this account instead - thank you for your understanding.
Page Cursor
fix: page cursor position stays the same between page selection
Given a query with multiple result pages, if the cursor is moved to a result entry, then the user selects a different page, the cursor remains on the previous position.
Pagination
fix: search results not displaying on first page
Given a query with multiple result pages, if a certain page is selected, then another query (with the same or more result pages as the previous entry) is searched, the results will display on the previously selected page.