Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update comment module "Artalk" #6901

Merged
merged 2 commits into from
Apr 25, 2024
Merged

feat: update comment module "Artalk" #6901

merged 2 commits into from
Apr 25, 2024

Conversation

CDN18
Copy link
Contributor

@CDN18 CDN18 commented Dec 23, 2023 •
edited

The Artalk comment module is not compatible with Artalk v2.7+, which requires invocation on an instance created by either Artalk.init or new Artalk.

The original code.yml will result in below error:

Uncaught TypeError: Artalk is not a constructor
    onload https://<wiki-js-url>/:42
[<wiki-js-url>:42:5](https://<wiki-js-url>/)
    onload https://<wiki-js-url>/:42

The updated code.yml works for both v2.7+ and older versions (tested with v2.6.4)

@auto-assign auto-assign bot requested a review from NGPixel December 23, 2023 13:33
@NGPixel NGPixel merged commit f1161ae into requarks:main Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NGPixel NGPixel Awaiting requested review from NGPixel

Assignees

@NGPixel NGPixel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CDN18 @NGPixel