Add entity name to RowCountException #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
npurushe
reviewed
Mar 19, 2018
| private final long expected; | ||
| private final long actual; | ||
|
|
||
| RowCountException(long expected, long actual) { | ||
| super("Expected " + expected + " row affected actual " + actual); | ||
| RowCountException(String entityName, long expected, long actual) { |
There was a problem hiding this comment.
Looking at the usage it would be simpler if this argument was a Class instead of a String. That would simplify the usage in all the calling sites
There was a problem hiding this comment.
Thanks for the point, updated PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see
RowCountExceptionsometimes in the Crashlytics logs, but its message doesn't say which entity failed (and there is no root SQLException, which would say this), so the goal of this PR is to add failed entity name to the exception message.I also didn't fine any way to test throwing this exception, do you have any advice on that?