Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaking global variable: _key #9

Closed
crsmithdev opened this issue Nov 12, 2014 · 3 comments
Closed

Leaking global variable: _key #9

crsmithdev opened this issue Nov 12, 2014 · 3 comments

Comments

@crsmithdev
Copy link

This is tripping global leak detection in mocha in any project using this module.

Caseless.prototype.get = function (name) {
  name = name.toLowerCase()
  var result, key
  var headers = this.dict
  Object.keys(headers).forEach(function (key) {
    _key = key.toLowerCase()
    if (name === _key) result = headers[key]
  })
  return result
}
@jaw187
Copy link

jaw187 commented Nov 12, 2014

I just opened #8 to address this

simong added a commit to fronteerio/grasshopper that referenced this issue Nov 15, 2014
@owenallenaz
Copy link

It looks like this has been fixed, and the package.json was updated to 0.7.1 but npm publish hasn't been run yet.

@nylen
Copy link
Member

nylen commented Jan 12, 2015

looks like this is fixed. (btw .1 versions aren't published, so @owenallenaz you're looking for 0.8.0)

@nylen nylen closed this as completed Jan 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants